]> git.mjollnir.org Git - moodle.git/commit
Refactoring some critical parts
authorDavid Mudrak <david.mudrak@gmail.com>
Mon, 4 Jan 2010 18:02:05 +0000 (18:02 +0000)
committerDavid Mudrak <david.mudrak@gmail.com>
Mon, 4 Jan 2010 18:02:05 +0000 (18:02 +0000)
commit3dc78e5b04e42dfc93a1b1a51d391bf537370cbe
tree4344d5e91cffec50279049bc67fa1e3cdc9c8835
parent51508f2591abb638c04a77d0b55c84ddedccb084
Refactoring some critical parts

Critical issue fixed here: after recent refactorings, I called
get_users_with_capability() inside the loop in another loop! (oops :-)
This was used in my very first code using the renderers. I have learnt
I should follow the core approach (as suggested by Tim) to prepare a
data object and pass it to the renderer. The fact the renderer called
a workshop method indicated something was really wrong...

WIP
mod/workshop/allocation/manual/allocator.php
mod/workshop/allocation/manual/renderer.php
mod/workshop/allocation/random/allocator.php
mod/workshop/allocation/random/lang/en_utf8/workshopallocation_random.php
mod/workshop/develtools.php
mod/workshop/lang/en_utf8/workshop.php
mod/workshop/locallib.php
mod/workshop/submission.php
mod/workshop/switchphase.php
mod/workshop/view.php