blocks upgrade: MDL-20820 another blocks upgrade problem with sticky blocks

Even though the visible column is going to be dropped,
we need to set it here or the query at line 2087 will fail.

Huge thanks to Oleg Sychev who did all the debugging and testing for this fix.

diff --git a/lib/db/upgrade.php b/lib/db/upgrade.php
index d281ce0760ef9bf7ceb5cd8a4418b9864f1eff90..fb0e7c0ba447b7230336ec86cfc1f808722809b6 100644 (file)
--- a/lib/db/upgrade.php
+++ b/lib/db/upgrade.php
@@ -2043,6 +2043,7 @@ WHERE gradeitemid IS NOT NULL AND grademax IS NOT NULL");
             $newblock->defaultregion = $newregions[$stickyblock->position];
             $newblock->defaultweight = $stickyblock->weight;
             $newblock->configdata = $stickyblock->configdata;
+            $newblock->visible = 1;
             $DB->insert_record('block_instances', $newblock);
         }