AICC MDL-18702 Completion Logic incorrect - thanks to Martin Holden for the fix!

diff --git a/mod/scorm/aicc.php b/mod/scorm/aicc.php
index 672834591d9aa444f907eab87135812e50d9accc..0f46d6c228135b876b39a5250e88027918408e32 100755 (executable)
--- a/mod/scorm/aicc.php
+++ b/mod/scorm/aicc.php
@@ -265,10 +265,14 @@
                             if ($mode == 'normal') {
                                 if ($lessonstatus == 'completed') {
                                     if ($sco = scorm_get_sco($scoid)) {
-                                        if (!empty($sco->mastery_score) && !empty($score) && ($score >= $sco->mastery_score)) {
-                                            $lessonstatus = 'passed';
-                                        } else {
-                                            $lessonstatus = 'failed';
+                                        if (!empty($sco->mastery_score)) {
+                                            if (!empty($score)) {
+                                                if ($score >= $sco->mastery_score) {
+                                                    $lessonstatus = 'passed';
+                                                } else {
+                                                    $lessonstatus = 'failed';
+                                                }
+                                            }
                                         }
                                         $id = scorm_insert_track($USER->id, $scorm->id, $sco->id, $attempt, 'cmi.core.lesson_status', $lessonstatus);
                                     }