Bugfixes to set_user_preference

diff --git a/lib/moodlelib.php b/lib/moodlelib.php
index 394c20c4c7f4b30679d1b3aa7b7cef632ed86850..2c4d295c749095629c0098c0b0eef6a83502498c 100644 (file)
--- a/lib/moodlelib.php
+++ b/lib/moodlelib.php
@@ -99,13 +99,18 @@ function set_user_preference($name, $value) {
     }
 
     if ($preference = get_record('user_preferences', 'userid', $USER->id, 'name', $name)) {
-        return set_field("user_preferences", "value", $value, "id", $preference->id);
+        if (set_field("user_preferences", "value", $value, "id", $preference->id)) {
+            $USER->preference[$name] = $value;
+            return true;
+        } else {
+            return false;
+        }
 
     } else {
         $preference->userid = $USER->id;
         $preference->name   = $name;
         $preference->value  = (string)$value;
-        if (insert_record('user_preferences', $record)) {
+        if (insert_record('user_preferences', $preference)) {
             $USER->preference[$name] = $value;
             return true;
         } else {