]> git.mjollnir.org Git - moodle.git/commitdiff
Allow uploaded files to be declared in popup windows too.
authormoodler <moodler>
Sun, 19 Oct 2003 14:21:54 +0000 (14:21 +0000)
committermoodler <moodler>
Sun, 19 Oct 2003 14:21:54 +0000 (14:21 +0000)
course/lib.php
mod/resource/view.php

index b8ad44817b1642ad2e69b97d62f6361ee445eed7..6f9e31199581e3fa5211e1fa16cf8702dd43f21d 100644 (file)
@@ -385,9 +385,9 @@ function get_array_of_activities($courseid) {
                    // This part is an ugly hack that doesn't belong here//
                    if ($mod[$seq]->mod == "resource") {
                        if ($resource = get_record("resource", "id", $rawmods[$seq]->instance)) {
-                           if ($resource->type == 5 and $resource->alltext) {
+                           if (($resource->type == 3 or $resource->type == 5) and !empty($resource->alltext)) {
                                $mod[$seq]->extra = urlencode("target=\"resource$resource->id\" onClick=\"return ".
-                                                   "openpopup('/mod/resource/view.php?id=".
+                                                   "openpopup('/mod/resource/view.php?inpopup=true&id=".
                                                    $mod[$seq]->cm.
                                                    "','resource$resource->id','$resource->alltext');\"");
                            }
index 757c3833a73d1a0d7361095b7e31ec02f0264c15..a858c8208860f06b876cae283153ef1c85cd3983 100644 (file)
@@ -86,6 +86,8 @@
                 $fullurl = "$CFG->wwwroot/file.php?file=/$course->id/$resource->reference";
             }
 
+            $inpopup = !empty($_GET["inpopup"]);
+
             $embedded = false;
 
             if (mimeinfo("icon", $fullurl) == "image.gif") {  //  It's an image
                 $resourceimage = true;
             } else {
                 $resourceimage = false;
-            }
+            } // Later, look for more things to embed
 
-            // (could check for more embeddable media here...)
+            if ($inpopup) {
+                add_to_log($course->id, "resource", "view", "view.php?id=$cm->id", "$resource->id");
+                if ($embedded) {
+                    print_header($pagetitle);
+                    echo "<center><font size=-1>".text_to_html($resource->summary, true, false)."</font></center>";
+                } else {
+                    redirect($fullurl);
+                    break;
+                }
+
+            } else if ($frameset == "top" or $embedded) {
 
-            if ($frameset == "top" or $embedded) {
                 if ($frameset == "top") {
                     $targetwindow = "parent";
                 } else {
                     echo "<center><img class=\"resourceimage\" src=\"$fullurl\"></center>";
                     echo "<br />";
                 }
-                print_footer($course);
+                if (!$inpopup) {
+                    print_footer($course);
+                }
                 
             } else {               // Display resource in a frame of it's own.
                 echo "<head><title>$course->shortname: $resource->name</title></head>\n";