lots of incorrect required_param()'s - there MUST be only two parameters not three!!

diff --git a/course/participation.php b/course/participation.php
index acf8c3c395752f35df31494df58c35d2035800b2..cfbc28bc697653992d2e95cf443f1df6338a9bd9 100644 (file)
--- a/course/participation.php
+++ b/course/participation.php
@@ -5,7 +5,7 @@
 
     define('DEFAULT_PAGE_SIZE', 20);
     
-    $id         = required_param('id',0,PARAM_INT); // course id.
+    $id         = required_param('id',PARAM_INT); // course id.
     $moduleid   = optional_param('moduleid',0,PARAM_INT); // module id.
     $oldmod     = optional_param('oldmod',0,PARAM_INT);
     $teachers   = optional_param('teachers',0,PARAM_BOOL); // show teachers? off = students.

diff --git a/course/statsgraph.php b/course/statsgraph.php
index ddce74c5fc24a591697002d4625c216108999782..1943a3e3c65b036a3375d91dd665f65b5ca72a76 100644 (file)
--- a/course/statsgraph.php
+++ b/course/statsgraph.php
@@ -4,11 +4,11 @@
     require_once($CFG->dirroot.'/lib/statslib.php');
     require_once($CFG->dirroot.'/lib/graphlib.php');
 
-    $courseid = required_param('course',0,PARAM_INT);
-    $report = required_param('report',0,PARAM_INT);
-    $time = required_param('time',0,PARAM_INT);
-    $userid = optional_param('userid',0,PARAM_INT);
-    $mode = required_param('mode',STATS_MODE_GENERAL,PARAM_INT);
+    $courseid = required_param('course',PARAM_INT);
+    $report = required_param('report',PARAM_INT);
+    $time = required_param('time',PARAM_INT);
+    $userid = optional_param('userid', 0, PARAM_INT);
+    $mode = required_param('mode',PARAM_INT);
 
     if (!$course = get_record("course","id",$courseid)) {
         error("That's an invalid course id");

diff --git a/mod/choice/index.php b/mod/choice/index.php
index 86c76bcb0be5dab2b3cbb139aff4bd00664ec13f..970d016aa2eb059046ccff404dacf86b7a015893 100644 (file)
--- a/mod/choice/index.php
+++ b/mod/choice/index.php
@@ -3,7 +3,7 @@
     require_once("../../config.php");
     require_once("lib.php");
 
-    $id = required_param('id',0,PARAM_INT);   // course
+    $id = required_param('id',PARAM_INT);   // course
 
     if (! $course = get_record("course", "id", $id)) {
         error("Course ID is incorrect");

diff --git a/mod/forum/subscribe.php b/mod/forum/subscribe.php
index 187e4da1fafcee34e041251200e828656abe98b9..323f299c8dceb8119e68f3f40eeeadde0de30c66 100644 (file)
--- a/mod/forum/subscribe.php
+++ b/mod/forum/subscribe.php
@@ -5,7 +5,7 @@
     require_once("../../config.php");
     require_once("lib.php");
 
-    $id = required_param('id',0,PARAM_INT);      // The forum to subscribe or unsubscribe to
+    $id = required_param('id',PARAM_INT);      // The forum to subscribe or unsubscribe to
     $force = optional_param('force','',PARAM_ALPHA);  // Force everyone to be subscribed to this forum?
     $user = optional_param('user',0,PARAM_INT);
 

diff --git a/mod/glossary/exportentry.php b/mod/glossary/exportentry.php
index 06ab91def2be51f2d4f29581aa80e65ff8e0be9e..a1695ebef4cd75e1b225b6ab8e88569f739fc9f9 100644 (file)
--- a/mod/glossary/exportentry.php
+++ b/mod/glossary/exportentry.php
@@ -3,7 +3,7 @@
     require_once('lib.php');
 
     $id    = required_param('id', PARAM_INT);           // course module ID
-    $entry = required_param('entry', 0, PARAM_INT);     // Entry ID
+    $entry = required_param('entry', PARAM_INT);     // Entry ID
     $confirm = optional_param('confirm', 0, PARAM_INT); // confirmation
 
     $hook = optional_param('hook', '', PARAM_ALPHANUM);

diff --git a/mod/quiz/edit.php b/mod/quiz/edit.php
index 1c6edd373859121aa22c94a269768267275c2bf1..5c9bc35540742499434480e87575d3537a76e279 100644 (file)
--- a/mod/quiz/edit.php
+++ b/mod/quiz/edit.php
@@ -219,7 +219,7 @@ if (self.name == 'editquestion') {
 
     if (isset($_REQUEST['repaginate']) and confirm_sesskey()) { /// Re-paginate the quiz
         if (isset($_REQUEST['questionsperpage'])) {
-            $modform->questionsperpage = required_param('questionsperpage', 1, PARAM_INT);
+            $modform->questionsperpage = required_param('questionsperpage', PARAM_INT);
             if (!set_field('quiz', 'questionsperpage', $modform->questionsperpage, 'id', $modform->id)) {
                 error('Could not save number of questions per page');
             }

diff --git a/mod/resource/index.php b/mod/resource/index.php
index 4331f0b766fc4c652a266e9685d22929f055bce8..221ce1020ddeea42a4b1ec0df25e37fb03d412a4 100644 (file)
--- a/mod/resource/index.php
+++ b/mod/resource/index.php
@@ -2,7 +2,7 @@
 
     require_once("../../config.php");
 
-    $id = required_param( 'id', 0, PARAM_INT ); // course
+    $id = required_param( 'id', PARAM_INT ); // course
 
     if (!empty($CFG->forcelogin)) {
         require_login();

diff --git a/mod/scorm/aicc.php b/mod/scorm/aicc.php
index 6c61e6b525a169b0abb27da42a921948a2b5c743..450b46761687eef42306df665b7017fdf42283c9 100755 (executable)
--- a/mod/scorm/aicc.php
+++ b/mod/scorm/aicc.php
@@ -2,8 +2,8 @@
     require_once('../../config.php');
     require_once('locallib.php');
 
-    $command = required_param('command', '', PARAM_ALPHA);
-    $sessionid = required_param('session_id', '', PARAM_ALPHANUM);
+    $command = required_param('command', PARAM_ALPHA);
+    $sessionid = required_param('session_id', PARAM_ALPHANUM);
     $aiccdata = optional_param('aicc_data', '', PARAM_RAW);
 
     require_login();

diff --git a/mod/scorm/api.php b/mod/scorm/api.php
index c8afcb41eddae6069f952d16daf8af3cd32e78d5..2d47e1bcb0e1db79016d7adca522335a009c4e5a 100644 (file)
--- a/mod/scorm/api.php
+++ b/mod/scorm/api.php
@@ -5,9 +5,9 @@
 
     $id = optional_param('id', '', PARAM_INT);       // Course Module ID, or
     $a = optional_param('a', '', PARAM_INT);         // scorm ID
-    $scoid = required_param('scoid', '', PARAM_INT);  // sco ID
+    $scoid = required_param('scoid', PARAM_INT);  // sco ID
     $mode = optional_param('mode', '', PARAM_ALPHA); // navigation mode
-    $attempt = required_param('attempt', '', PARAM_INT); // new attempt
+    $attempt = required_param('attempt', PARAM_INT); // new attempt
 
     if (!empty($id)) {
         if (! $cm = get_record("course_modules", "id", $id)) {

diff --git a/mod/scorm/datamodel.php b/mod/scorm/datamodel.php
index 5e3b1f8f1608d4bd7d30bc3665f01e81dd530b5a..a253d98e8736105e38a50bf8e4cda8c74777119d 100755 (executable)
--- a/mod/scorm/datamodel.php
+++ b/mod/scorm/datamodel.php
@@ -4,8 +4,8 @@
     
     $id = optional_param('id', '', PARAM_INT);       // Course Module ID, or
     $a = optional_param('a', '', PARAM_INT);         // scorm ID
-    $scoid = required_param('scoid', '', PARAM_INT);  // sco ID
-    $attempt = required_param('attempt', '', PARAM_INT);  // attempt number
+    $scoid = required_param('scoid', PARAM_INT);  // sco ID
+    $attempt = required_param('attempt', PARAM_INT);  // attempt number
 
     if (!empty($id)) {
         if (! $cm = get_record("course_modules", "id", $id)) {

diff --git a/mod/scorm/index.php b/mod/scorm/index.php
index 098b52c454436b308caa7a75e8ade3a9dcdb2846..faffd41b8fc4f6cfedf5e9985318a23e6d9fcff4 100755 (executable)
--- a/mod/scorm/index.php
+++ b/mod/scorm/index.php
@@ -2,7 +2,7 @@
 
     require_once("../../config.php");
 
-    $id = required_param('id', '', PARAM_INT);   // course id
+    $id = required_param('id', PARAM_INT);   // course id
 
     if (!empty($id)) {
         if (! $course = get_record("course", "id", $id)) {

diff --git a/mod/scorm/loadSCO.php b/mod/scorm/loadSCO.php
index 71901edf08720e91a085bb2acc665ed52fca2c73..2b303b432c2b2af64ad75164349693e75fb55266 100755 (executable)
--- a/mod/scorm/loadSCO.php
+++ b/mod/scorm/loadSCO.php
@@ -4,7 +4,7 @@
 
     $id = optional_param('id', '', PARAM_INT);       // Course Module ID, or
     $a = optional_param('a', '', PARAM_INT);         // scorm ID
-    $scoid = required_param('scoid', '', PARAM_INT); // sco ID
+    $scoid = required_param('scoid', PARAM_INT); // sco ID
 
     if (!empty($id)) {
         if (! $cm = get_record("course_modules", "id", $id)) {

diff --git a/mod/scorm/player.php b/mod/scorm/player.php
index 9167a3d5542b850ba917a09c3b1de69f3352394d..cb3e56fd997d1302029d3c496c1e0bdb5225e006 100755 (executable)
--- a/mod/scorm/player.php
+++ b/mod/scorm/player.php
@@ -10,7 +10,7 @@
     //
     $id = optional_param('id', '', PARAM_INT);       // Course Module ID, or
     $a = optional_param('a', '', PARAM_INT);         // scorm ID
-    $scoid = required_param('scoid', '', PARAM_INT);  // sco ID
+    $scoid = required_param('scoid', PARAM_INT);  // sco ID
     $mode = optional_param('mode', 'normal', PARAM_ALPHA); // navigation mode
     $currentorg = optional_param('currentorg', '', PARAM_RAW); // selected organization
     $newattempt = optional_param('newattempt', 'off', PARAM_ALPHA); // the user request to start a new attempt

diff --git a/mod/scorm/validate.php b/mod/scorm/validate.php
index f1e223219b113821e7ded91beac9acf6cd313acf..d1a6988d75c4830823a6b94a8bd17a55828fddb5 100755 (executable)
--- a/mod/scorm/validate.php
+++ b/mod/scorm/validate.php
@@ -3,8 +3,8 @@
     require_once("../../config.php");
     require_once('locallib.php');
 
-    $courseid = required_param('id', '', PARAM_INT);             // Course Module ID, or
-    $reference = required_param('reference', '', PARAM_PATH);    // Package path
+    $courseid = required_param('id', PARAM_INT);             // Course Module ID, or
+    $reference = required_param('reference', PARAM_PATH);    // Package path
     $scormid = optional_param('instance', '', PARAM_INT);       // scorm ID
 
     require_login($courseid, false);