formslib: MDL-13210 - partial - try to make validation errores less annoying.

I have made them float right, and reduced the padding on the red box, so they don't cuause the height of the form to change so much, if the error fits to the right of the form control. I realise that some people may not like this, which I why I have done this in head only for now. I will revert this if told to.

diff --git a/admin/roles/lib.php b/admin/roles/lib.php
index 03ba3967296511926f35335bd3e799fe9d4fa5d8..a2874e00c7dabc273d921f54849a590daffcfdf5 100644 (file)
--- a/admin/roles/lib.php
+++ b/admin/roles/lib.php
@@ -674,7 +674,6 @@ class define_role_table_advanced extends capability_table_with_risks {
         echo '<div class="felement' . $extraclass . '">';
         if (isset($this->errors[$name])) {
             formerr($this->errors[$name]);
-            echo '<br />';
         }
         echo $field;
         echo '</div>';

diff --git a/theme/standard/styles_layout.css b/theme/standard/styles_layout.css
index 51c4243881c1f2692a694e8049392993312bcdb2..cd1afd546c50fa493a1c93ef8189c1264f85a627 100644 (file)
--- a/theme/standard/styles_layout.css
+++ b/theme/standard/styles_layout.css
@@ -669,10 +669,11 @@ fieldset.fdate_selector label {
 }
 .mform span.error, .mform span.required {
   color: red;
+  float: right;
+  margin-right: 0.3em;
 }
 .mform div.error,.mform fieldset.error {
   border: 1px solid red;
-  padding: 5px;
   color: inherit;
 }
 .mform .fcheckbox input {