MDL-12593 - hidden role assignment icon wasn't being shown. Also prevent warning

about unset $hidden

merged from MOODLE_19_STABLE

diff --git a/user/index.php b/user/index.php
index fd5060abd3d27e2ad6495f307ed5ce38025911dc..43148cf8fa1a7cdd140229c942ff63deea2229e1 100644 (file)
--- a/user/index.php
+++ b/user/index.php
@@ -641,9 +641,9 @@
             
             while ($user = rs_fetch_next_record($userlist)) {
                 $user = make_context_subobj($user);
-                if ($user->hidden) {
+                if ( !empty($user->hidden) ) {
                 // if the assignment is hidden, display icon
-                    $hidden = "<img src=\"{$CFG->pixpath}/t/hide.gif\" alt=\"".get_string('hiddenassign')."\" class=\"hide-show-image\"/>";
+                    $hidden = " <img src=\"{$CFG->pixpath}/t/hide.gif\" alt=\"".get_string('hiddenassign')."\" class=\"hide-show-image\"/>";
                 } else {
                     $hidden = '';
                 }
@@ -680,7 +680,7 @@
 
                 $data = array (
                         print_user_picture($user, $course->id, $user->picture, false, true, $piclink),
-                        $profilelink);
+                        $profilelink . $hidden);
 
                 if ($mode === MODE_BRIEF && !isset($hiddenfields['city'])) {
                     $data[] = $user->city;