unit test reliability: For some reason this does not work on my laptop. because the...

diff --git a/mod/quiz/simpletest/testaccessrules.php b/mod/quiz/simpletest/testaccessrules.php
index 72a57e55fb92993744a864c9e42690036c01a309..2c767c80edee2a86b61c9fd8665c1e48b45c8693 100644 (file)
--- a/mod/quiz/simpletest/testaccessrules.php
+++ b/mod/quiz/simpletest/testaccessrules.php
@@ -43,15 +43,19 @@ class simple_rules_test extends MoodleUnitTestCase {
         $quiz = new stdClass;
         $attempt = new stdClass;
 
+        // Test the allowed case by getting the user's IP address. However, this
+        // does not always work, for example using the mac install package on my laptop.
         $quiz->subnet = getremoteaddr();
-        $quiz->questions = '';
-        $quizobj = new quiz($quiz, null, null);
-        $rule = new ipaddress_access_rule($quizobj, 0);
-        $this->assertFalse($rule->prevent_access());
-        $this->assertFalse($rule->description());
-        $this->assertFalse($rule->prevent_new_attempt(0, $attempt));
-        $this->assertFalse($rule->is_finished(0, $attempt));
-        $this->assertFalse($rule->time_left($attempt, 1));
+        if (!empty($quiz->subnet)) {
+            $quiz->questions = '';
+            $quizobj = new quiz($quiz, null, null);
+            $rule = new ipaddress_access_rule($quizobj, 0);
+            $this->assertFalse($rule->prevent_access());
+            $this->assertFalse($rule->description());
+            $this->assertFalse($rule->prevent_new_attempt(0, $attempt));
+            $this->assertFalse($rule->is_finished(0, $attempt));
+            $this->assertFalse($rule->time_left($attempt, 1));
+        }
 
         $quiz->subnet = '0.0.0.0';
         $quiz->questions = '';