fixed capitalization and quoting of attribute values

diff --git a/mod/chat/backuplib.php b/mod/chat/backuplib.php
index af7dc77a16f9bef3043e918790eb490dd94a032d..b6e34f88558697c3bace369c80c53e3089a5336c 100644 (file)
--- a/mod/chat/backuplib.php
+++ b/mod/chat/backuplib.php
@@ -1,4 +1,4 @@
-<?PHP //$Id$
+<?php //$Id$
     //This php script contains all the stuff to backup/restore
     //chat mods
 

diff --git a/mod/chat/chatd.php b/mod/chat/chatd.php
index f940efe49a28aec707bfc7e7d879b832c75dd098..0085b636f0d7d43e93eb21bf7cf5a35944d01d28 100755 (executable)
--- a/mod/chat/chatd.php
+++ b/mod/chat/chatd.php
@@ -262,8 +262,8 @@ class ChatDaemon {
                 echo '<tr><td width="35">';
                 echo '<a target="_new" onclick="return openpopup('.$popuppar.');" href="'.$CFG->wwwroot.'/user/view.php?id='.$userinfo['chatuser']->id.'&amp;course='.$userinfo['courseid'].'">';
                 print_user_picture($userinfo['user']->id, 0, $userinfo['user']->picture, false, false, false);
-                echo "</a></td><td valign=center>";
-                echo "<p><font size=1>";
+                echo "</a></td><td valign=\"center\">";
+                echo "<p><font size=\"1\">";
                 echo fullname($userinfo['user'])."<br />";
                 echo "<font color=\"#888888\">$str->idle: ".format_time($lastping, $str)."</font> ";
                 echo '<a target="empty" href="http://'.$CFG->chat_serverhost.':'.$CFG->chat_serverport.'/?win=beep&beep='.$userinfo['user']->id.
@@ -365,7 +365,7 @@ class ChatDaemon {
 
                 // The refresh value is 2 seconds higher than the configuration variable because we are doing JS refreshes all the time.
                 // However, if the JS doesn't work for some reason, we still want to refresh once in a while.
-                $header .= "Refresh: ".(intval($CFG->chat_refresh_userlist) + 2)."; URL=http://$CFG->chat_serverhost:$CFG->chat_serverport/?win=users&".
+                $header .= "Refresh: ".(intval($CFG->chat_refresh_userlist) + 2)."; url=http://$CFG->chat_serverhost:$CFG->chat_serverport/?win=users&".
                            "chat_sid=".$sessionid."&groupid=".$this->sets_info[$sessionid]['groupid']."\n";
                 $header .= "\n";
 

diff --git a/mod/chat/config.html b/mod/chat/config.html
index a08339d4c136b7f6768323ee64b347639241bf6b..a8e5c5408df8d2995eecc8cb60596c271fbdcbfc 100644 (file)
--- a/mod/chat/config.html
+++ b/mod/chat/config.html
@@ -1,17 +1,17 @@
 <form method="post" action="module.php" name="form">
 
-<table cellpadding=9 cellspacing=0 >
+<table cellpadding="9" cellspacing="0" >
 
 <tr>
-  <td colspan=3 align=center>
+  <td colspan="3" align="center">
      <div><b><?php print_string('generalconfig', 'chat')?></b></div>
      <div style="font-size: 0.8em;">(<?php print_string('explaingeneralconfig', 'chat')?>)</div>
   </td>
 </tr>
 
 
-<tr valign=top>
-       <td align=right><p>chat_method:</td>
+<tr valign="top">
+       <td align="right"><p>chat_method:</td>
        <td>
     <?php
        unset($options);
@@ -24,19 +24,19 @@
     <?php print_string("configmethod", "chat") ?>
     </td>
 </tr>
-<tr valign=top>
-       <td align=right><p>chat_refresh_userlist:</td>
+<tr valign="top">
+       <td align="right"><p>chat_refresh_userlist:</td>
        <td>
-    <input name=chat_refresh_userlist type=text size=5 value="<?php p($CFG->chat_refresh_userlist) ?>">
+    <input name="chat_refresh_userlist" type="text" size="5" value="<?php p($CFG->chat_refresh_userlist) ?>">
     </td>
     <td>
     <?php print_string("configrefreshuserlist", "chat") ?>
     </td>
 </tr>
-<tr valign=top>
-       <td align=right><p>chat_old_ping:</td>
+<tr valign="top">
+       <td align="right"><p>chat_old_ping:</td>
        <td>
-    <input name=chat_old_ping type=text size=5 value="<?php p($CFG->chat_old_ping) ?>">
+    <input name="chat_old_ping" type="text" size="5" value="<?php p($CFG->chat_old_ping) ?>">
     </td>
     <td>
     <?php print_string("configoldping", "chat") ?>
@@ -44,16 +44,16 @@
 </tr>
 
 <tr>
-  <td colspan=3 align=center><hr />
+  <td colspan="3" align="center"><hr />
      <div><b><?php print_string('methodnormal', 'chat')?></b></div>
      <div style="font-size: 0.8em;">(<?php print_string('explainmethodnormal', 'chat')?>)</div>
   </td>
 </tr>
 
-<tr valign=top>
-       <td align=right><p>chat_refresh_room:</td>
+<tr valign="top">
+       <td align="right"><p>chat_refresh_room:</td>
        <td>
-    <input name=chat_refresh_room type=text size=5 value="<?php p($CFG->chat_refresh_room) ?>">
+    <input name="chat_refresh_room" type="text" size="5" value="<?php p($CFG->chat_refresh_room) ?>">
     </td>
     <td>
     <?php print_string("configrefreshroom", "chat") ?>
@@ -61,43 +61,43 @@
 </tr>
 
 <tr>
-  <td colspan=3 align=center><hr />
+  <td colspan="3" align="center"><hr />
      <div><b><?php print_string('methoddaemon', 'chat')?></b></div>
      <div style="font-size: 0.8em;">(<?php print_string('explainmethoddaemon', 'chat')?>)</div>
   </td>
 </tr>
 
-<tr valign=top>
-       <td align=right><p>chat_serverhost:</td>
+<tr valign="top">
+       <td align="right"><p>chat_serverhost:</td>
        <td>
-    <input name=chat_serverhost type=text size=20 value="<?php p($CFG->chat_serverhost) ?>">
+    <input name="chat_serverhost" type="text" size="20" value="<?php p($CFG->chat_serverhost) ?>">
     </td>
     <td>
     <?php print_string("configserverhost", "chat") ?>
     </td>
 </tr>
-<tr valign=top>
-       <td align=right><p>chat_serverip:</td>
+<tr valign="top">
+       <td align="right"><p>chat_serverip:</td>
        <td>
-    <input name=chat_serverip type=text size=16 value="<?php p($CFG->chat_serverip) ?>">
+    <input name="chat_serverip" type="text" size="16" value="<?php p($CFG->chat_serverip) ?>">
     </td>
     <td>
     <?php print_string("configserverip", "chat") ?>
     </td>
 </tr>
-<tr valign=top>
-       <td align=right><p>chat_serverport:</td>
+<tr valign="top">
+       <td align="right"><p>chat_serverport:</td>
        <td>
-    <input name=chat_serverport type=text size=5 value="<?php p($CFG->chat_serverport) ?>">
+    <input name="chat_serverport" type="text" size="5" value="<?php p($CFG->chat_serverport) ?>">
     </td>
     <td>
     <?php print_string("configserverport", "chat") ?>
     </td>
 </tr>
-<tr valign=top>
-       <td align=right><p>chat_servermax:</td>
+<tr valign="top">
+       <td align="right"><p>chat_servermax:</td>
        <td>
-    <input name=chat_servermax type=text size=5 value="<?php p($CFG->chat_servermax) ?>">
+    <input name="chat_servermax" type="text" size="5" value="<?php p($CFG->chat_servermax) ?>">
     </td>
     <td>
     <?php print_string("configservermax", "chat") ?>
@@ -105,7 +105,7 @@
 </tr>
 
 <tr>
-    <td colspan=3 align=center>
+    <td colspan="3" align="center">
        <input type="submit" value="<?php print_string("savechanges") ?>"></td>
 </tr>
 </table>

diff --git a/mod/chat/db/mysql.php b/mod/chat/db/mysql.php
index 1bb74215a321545394cfb1c766a9ec246273b587..76608fe3de38aa5bfa2a79d211c4b4ae9796dc74 100644 (file)
--- a/mod/chat/db/mysql.php
+++ b/mod/chat/db/mysql.php
@@ -1,4 +1,4 @@
-<?PHP // $Id$
+<?php // $Id$
 
 function chat_upgrade($oldversion) {
 // This function does anything necessary to upgrade

diff --git a/mod/chat/db/oci8po.php b/mod/chat/db/oci8po.php
index aca0fe44c0947e72190ab1e109e6e738969f625e..1adaac760c4c709107b098027e8145ab47b0170f 100755 (executable)
--- a/mod/chat/db/oci8po.php
+++ b/mod/chat/db/oci8po.php
@@ -1,4 +1,4 @@
-<?PHP 
+<?php 
 
 function chat_upgrade($oldversion) {
 // This function does anything necessary to upgrade

diff --git a/mod/chat/db/postgres7.php b/mod/chat/db/postgres7.php
index 5857707014b3956d0f9f45870c5cdd5f0200b826..311f95fe62bf0cbf77c1499ef49d57ac27f14152 100644 (file)
--- a/mod/chat/db/postgres7.php
+++ b/mod/chat/db/postgres7.php
@@ -1,4 +1,4 @@
-<?PHP // $Id$
+<?php // $Id$
 
 function chat_upgrade($oldversion) {
 // This function does anything necessary to upgrade

diff --git a/mod/chat/drawboard.php b/mod/chat/drawboard.php
index 5edb4e9e31f3e1264fd1ec5a8c3199bb2f2aa8a2..099b1e7c3315dfa4f5b41526244dae19c9bc2606 100644 (file)
--- a/mod/chat/drawboard.php
+++ b/mod/chat/drawboard.php
@@ -16,16 +16,16 @@ if ($arsc_a["anzahl"] == 1)
    </title>
   </head>
   <body bgcolor="#000000" topmargin="0" leftmargin="0" marginleft="0" margintop="0">
-   <APPLET CODE="drawboard/Main.class" WIDTH="<?php echo $arsc_parameters["drawboard_width"]; ?>" HEIGHT="<?php echo $arsc_parameters["drawboard_height"]; ?>">
+   <applet code="drawboard/Main.class" width="<?php echo $arsc_parameters["drawboard_width"]; ?>" height="<?php echo $arsc_parameters["drawboard_height"]; ?>">
     <param name="port" value="<?php echo $arsc_parameters["drawboard_port"]; ?>">
     <param name="bgcolor" value="FFFFFF">
-    <PARAM NAME="menubgcolor" VALUE="FAE6A6">
-    <PARAM NAME="emptythumbnailcolor" VALUE="FDF0C6">
-    <PARAM NAME="countercolor" VALUE="000000">
+    <param name="menubgcolor" value="FAE6A6">
+    <param name="emptythumbnailcolor" value="FDF0C6">
+    <param name="countercolor" value="000000">
     <param name="pencolor" value="0000FF">
-    <PARAM NAME="skindef" VALUE="abacho/abacho.def">
+    <param name="skindef" value="abacho/abacho.def">
     Unfortunatelly, your browser doesn't support Java applets. You have to use another one.
-   </APPLET>
+   </applet>
   </body>
  </html>
  <?php

diff --git a/mod/chat/gui_header/chatinput.php b/mod/chat/gui_header/chatinput.php
index 24f6c3ea1cd33916a7d32a1429a42e58b0dfeb65..9d65bccb4dd5ddc339c5c875e43b0f483081ad13 100644 (file)
--- a/mod/chat/gui_header/chatinput.php
+++ b/mod/chat/gui_header/chatinput.php
@@ -11,7 +11,7 @@ if ($arsc_my = arsc_getdatafromsid($arsc_sid))
  {
   echo $arsc_parameters["htmlhead_msginput"];
   ?>
-    <form action="../shared/chatins.php" METHOD="POST" name="f">
+    <form action="../shared/chatins.php" method="POST" name="f">
      <input type="hidden" name="arsc_sid" value="<?php echo $arsc_sid; ?>">
      <input type="hidden" name="arsc_chatversion" value="header">
      <input type="text" name="arsc_message" size="50" maxlength="<?php echo $arsc_parameters["input_maxsize"]; ?>" value="<?php echo $arsc_pretext; ?>">

diff --git a/mod/chat/gui_header/chatmsg.php b/mod/chat/gui_header/chatmsg.php
index 3f399b36bfe3423b61a4dc595da9f0d0ba0876c6..9679568d5368620ab4518722361cb02285a09cb8 100644 (file)
--- a/mod/chat/gui_header/chatmsg.php
+++ b/mod/chat/gui_header/chatmsg.php
@@ -44,7 +44,7 @@ if ($arsc_my = arsc_getdatafromsid($arsc_sid))
   header("Cache-Control: no-cache, must-revalidate");
   header("Pragma: no-cache");
   header("Content-Type: text/html");
-  header("Refresh: 4; URL=chatmsg.php?arsc_sid=".$arsc_sid."&arsc_lastid=".$arsc_lastid."&dummy=".time()."#end");
+  header("Refresh: 4; url=chatmsg.php?arsc_sid=".$arsc_sid."&arsc_lastid=".$arsc_lastid."&dummy=".time()."#end");
   echo $arsc_parameters["htmlhead"];
   
   set_magic_quotes_runtime(0);

diff --git a/mod/chat/gui_header/index.php b/mod/chat/gui_header/index.php
index ffaf8270787fab5f83d0e17385bbe52521491466..ea29bf7bbe551fdae33d38ac8ab1b4412ff19434 100644 (file)
--- a/mod/chat/gui_header/index.php
+++ b/mod/chat/gui_header/index.php
@@ -12,7 +12,7 @@ include("../functions.inc.php");
  <frameset cols="193,*,120" border="0" framespacing="no" frameborder="0" marginwidth="2" marginheight="1">
   <frame src="../shared/roomlist.php?arsc_sid=<?php echo $arsc_sid; ?>" name="roomlist" scrolling="auto" noresize marginwidth="0" marginheight="0">
   <frameset rows="*,40" border="1" framespacing="no" frameborder="0" marginwidth="2" marginheight="1">
-   <frame src="chatmsg.php?arsc_sid=<?php echo $arsc_sid; ?>#end" NAME="msg" scrolling="auto" noresize marginwidth="2" marginheight="1">
+   <frame src="chatmsg.php?arsc_sid=<?php echo $arsc_sid; ?>#end" name="msg" scrolling="auto" noresize marginwidth="2" marginheight="1">
    <frame src="chatinput.php?arsc_sid=<?php echo $arsc_sid; ?>" name="input"  scrolling="no" noresize marginwidth="2" marginheight="1">
   </frameset>
   <frame src="../shared/userlist.php?arsc_sid=<?php echo $arsc_sid; ?>&arsc_enter=true" name="users" scrolling="auto" noresize marginwidth="5" marginheight="5">

diff --git a/mod/chat/gui_header_js/index.php b/mod/chat/gui_header_js/index.php
index 82e69f2bfe44613747b3372813f01852c6dd3b11..d9bb98f52e4b207efecd994281b3d2bfb619dbcb 100644 (file)
--- a/mod/chat/gui_header_js/index.php
+++ b/mod/chat/gui_header_js/index.php
@@ -62,9 +62,9 @@
  </head>
  <frameset cols="*,200" border="5" framespacing="no" frameborder="yes" marginwidth="2" marginheight="1">
   <frameset rows="0,0,*,40" border="0" framespacing="no" frameborder="no" marginwidth="2" marginheight="1">
-   <frame src="../empty.php" NAME="empty" scrolling="no" marginwidth="0" marginheight="0">
+   <frame src="../empty.php" name="empty" scrolling="no" marginwidth="0" marginheight="0">
    <frame src="jsupdate.php?<?php echo $params ?>" scrolling="no" marginwidth="0" marginheight="0">
-   <frame src="chatmsg.php" NAME="msg" scrolling="auto" marginwidth="2" marginheight="1">
+   <frame src="chatmsg.php" name="msg" scrolling="auto" marginwidth="2" marginheight="1">
    <frame src="chatinput.php?<?php echo $params ?>" name="input" scrolling="no" marginwidth="2" marginheight="1">
   </frameset>
   <frame src="../users.php?<?php echo $params ?>" name="users" scrolling="auto" marginwidth="5" marginheight="5">

diff --git a/mod/chat/gui_header_js/jsupdate.php b/mod/chat/gui_header_js/jsupdate.php
index 659df29e32740b712f6dcafe83013d14f9cb24a3..d338d82b12742249da4346a066b2d2f23d3be02e 100644 (file)
--- a/mod/chat/gui_header_js/jsupdate.php
+++ b/mod/chat/gui_header_js/jsupdate.php
@@ -33,7 +33,7 @@ header("Last-Modified: ".gmdate("D, d M Y H:i:s")." GMT");
 header("Cache-Control: no-cache, must-revalidate");
 header("Pragma: no-cache");
 header("Content-Type: text/html");
-header("Refresh: $CFG->chat_refresh_room; URL=jsupdate.php?chat_sid=$chat_sid&chat_lasttime=$chat_newlasttime&groupid=$groupid");
+header("Refresh: $CFG->chat_refresh_room; url=jsupdate.php?chat_sid=$chat_sid&chat_lasttime=$chat_newlasttime&groupid=$groupid");
 
 ?>
   <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">

diff --git a/mod/chat/gui_push_js/index.php b/mod/chat/gui_push_js/index.php
index 656d18cdf87005e662893da5736cec20d95eb348..6b1ff9c458a64fab155bc8e1bf3c24e5711e1960 100644 (file)
--- a/mod/chat/gui_push_js/index.php
+++ b/mod/chat/gui_push_js/index.php
@@ -12,8 +12,8 @@ include("../functions.inc.php");
  <frameset cols="193,*,120" border="0" framespacing="no" frameborder="0" marginwidth="2" marginheight="1">
   <frame src="../shared/roomlist.php?arsc_sid=<?php echo $arsc_sid; ?>" name="roomlist" scrolling="auto" noresize marginwidth="0" marginheight="0">
   <frameset rows="1,*,40" border="1" framespacing="no" frameborder="0" marginwidth="2" marginheight="1">
-   <frame src="../shared/empty.php" NAME="empty" scrolling="no" noresize marginwidth="0" marginheight="0">
-   <frame src="chatmsg.php?arsc_sid=<?php echo $arsc_sid; ?>" NAME="msg" scrolling="auto" noresize marginwidth="2" marginheight="1">
+   <frame src="../shared/empty.php" name="empty" scrolling="no" noresize marginwidth="0" marginheight="0">
+   <frame src="chatmsg.php?arsc_sid=<?php echo $arsc_sid; ?>" name="msg" scrolling="auto" noresize marginwidth="2" marginheight="1">
    <frame src="chatinput.php?arsc_sid=<?php echo $arsc_sid; ?>" name="input"  scrolling="no" noresize marginwidth="2" marginheight="1">
   </frameset>
   <frame src="../shared/userlist.php?arsc_sid=<?php echo $arsc_sid; ?>&arsc_enter=true" name="users" scrolling="auto" noresize marginwidth="5" marginheight="5">

diff --git a/mod/chat/gui_sockets/index.php b/mod/chat/gui_sockets/index.php
index b55d38fbba6cbf98e775b1ee3b786b641ef763fb..6a1532a313a2761a2118242076c364e18df05be8 100644 (file)
--- a/mod/chat/gui_sockets/index.php
+++ b/mod/chat/gui_sockets/index.php
@@ -63,7 +63,7 @@
  <frameset cols="*,200" border="5" framespacing="no" frameborder="yes" marginwidth="2" marginheight="1">
   <frameset rows="0,*,40" border="0" framespacing="no" frameborder="no" marginwidth="2" marginheight="1">
    <frame src="empty.php" name="empty" scrolling="auto" noresize marginwidth="2" marginheight="0">
-   <frame src="<?php echo "http://$CFG->chat_serverhost:$CFG->chat_serverport?win=chat&amp;$params"; ?>" NAME="msg" scrolling="auto" noresize marginwidth="2" marginheight="0">
+   <frame src="<?php echo "http://$CFG->chat_serverhost:$CFG->chat_serverport?win=chat&amp;$params"; ?>" name="msg" scrolling="auto" noresize marginwidth="2" marginheight="0">
    <frame src="chatinput.php?<?php echo $params ?>" name="input" scrolling="no" marginwidth="2" marginheight="1">
   </frameset>
   <frame src="<?php echo "http://$CFG->chat_serverhost:$CFG->chat_serverport?win=users&amp;$params"; ?>" name="users" scrolling="auto" marginwidth="5" marginheight="5">

diff --git a/mod/chat/gui_text/index.php b/mod/chat/gui_text/index.php
index 7d16dbfc934d75e437a605f2ab37a9cd929ca3ed..00b65b56154532ec9f8d8d8584cc02c48ce8269c 100644 (file)
--- a/mod/chat/gui_text/index.php
+++ b/mod/chat/gui_text/index.php
@@ -34,7 +34,7 @@ if ($arsc_my = arsc_getdatafromsid($arsc_sid))
   <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
   <html>
    <body>
-    <?php echo arsc_filter_posting("System", date("H:i:s"), "<font size=4><b>".$arsc_message."</b></font>", $arsc_room, 0); ?>
+    <?php echo arsc_filter_posting("System", date("H:i:s"), "<font size=\"4\"><b>".$arsc_message."</b></font>", $arsc_room, 0); ?>
    </body>
   </html>
   <?php
@@ -63,7 +63,7 @@ if ($arsc_my = arsc_getdatafromsid($arsc_sid))
     </title>
    </head>
    <body>
-    <form action="../shared/chatins.php" METHOD="POST">
+    <form action="../shared/chatins.php" method="POST">
      <a href="index.php?arsc_sid=<?php echo $arsc_sid; ?>&arsc_lastid=<?php echo $arsc_lastid; ?>"><?php echo $arsc_lang["refreshmessages"]; ?></a>
      <input type="hidden" name="arsc_sid" value="<?php echo $arsc_sid; ?>">
      <input type="hidden" name="arsc_lastid" value="<?php echo $arsc_lastid; ?>">

diff --git a/mod/chat/index.php b/mod/chat/index.php
index f2df2e3bd9a655c6f06c0e46316154e4fd867a8e..a10aba9fc1e1032c4c5ac293b3c6ef786e281b65 100644 (file)
--- a/mod/chat/index.php
+++ b/mod/chat/index.php
@@ -1,4 +1,4 @@
-<?PHP // $Id$
+<?php // $Id$
 
     require_once("../../config.php");
     require_once("lib.php");

diff --git a/mod/chat/lib.php b/mod/chat/lib.php
index 81f37fc635f7d89bc6e6a2657bc922a76bb408c1..130414d194ccc4531a344e04867ab16442d67671 100644 (file)
--- a/mod/chat/lib.php
+++ b/mod/chat/lib.php
@@ -1,4 +1,4 @@
-<?PHP  // $Id$
+<?php  // $Id$
 
 /// Library of functions and constants for module chat
 
@@ -190,12 +190,12 @@ function chat_print_recent_activity($course, $isteacher, $timestart) {
                     print_headline(get_string("currentchats", "chat").":");
                     $outputstarted = true;
                 }
-                echo "<p><font size=1><a href=\"$CFG->wwwroot/mod/chat/view.php?c=$chat->id\">$chat->name</a></font><br />";
+                echo "<p><font size=\"1\"><a href=\"$CFG->wwwroot/mod/chat/view.php?c=$chat->id\">$chat->name</a></font><br />";
             }
             $current = $chatuser->chatid;
         }
         $fullname = fullname($chatuser);
-        echo "&nbsp;&nbsp;&nbsp;<font size=1>- $fullname</font><br />";
+        echo "&nbsp;&nbsp;&nbsp;<font size=\"1\">- $fullname</font><br />";
     }
     echo "<br />";
 
@@ -714,7 +714,7 @@ function chat_format_message_manually($message, $courseid, $sender, $currentuser
 
     $output->text  = strip_tags($outinfo.': '.$outmain);
 
-    $output->html  = "<table><tr><td valign=top>$message->picture</td><td><font size=2>";
+    $output->html  = "<table><tr><td valign=\"top\">$message->picture</td><td><font size=\"2\">";
     $output->html .= "<font color=\"#888888\">$outinfo</font>";
     if ($outmain) {
         $output->html .= ": $outmain";

diff --git a/mod/chat/mod.html b/mod/chat/mod.html
index d91e1ed8b75af5b430448a8ed416a64653bbab0f..70b3d4bdd15196ec5e1677ef14bf3d7a052007b9 100644 (file)
--- a/mod/chat/mod.html
+++ b/mod/chat/mod.html
@@ -19,16 +19,16 @@
     }
 ?>
 <form name="form" method="post" action="mod.php">
-<table cellpadding=5>
+<table cellpadding="5">
 <tr>
-<tr valign=top>
-    <td align=right><p><b><?php print_string("chatname", "chat")?>:</b></p></td>
+<tr valign="top">
+    <td align="right"><p><b><?php print_string("chatname", "chat")?>:</b></p></td>
     <td>
-        <input type="text" name="name" size=30 value="<?php p($form->name) ?>">
+        <input type="text" name="name" size="30" value="<?php p($form->name) ?>">
     </td>
 </tr>
-<tr valign=top>
-    <td align=right><p><b><?php print_string("chatintro", "chat")?>:</b></p>
+<tr valign="top">
+    <td align="right"><p><b><?php print_string("chatintro", "chat")?>:</b></p>
     <font size="1">
      <?php
         helpbutton("writing", get_string("helpwriting"), "moodle", true, true);
@@ -44,16 +44,16 @@
         <?php print_textarea($usehtmleditor, 20, 50, 680, 400, "intro", $form->intro); ?>
     </td>
 </tr>
-<tr valign=top>
-    <td align=right><p><b><?php print_string("chattime", "chat") ?>:</b></td>
+<tr valign="top">
+    <td align="right"><p><b><?php print_string("chattime", "chat") ?>:</b></td>
     <td><?php
            print_date_selector("chatday", "chatmonth", "chatyear", $form->chattime);
            echo "&nbsp;-&nbsp;";
            print_time_selector("chathour", "chatminute", $form->chattime);
     ?></td>
 </tr>
-<tr valign=top>
-    <td align=right><p><b><?php print_string("repeattimes", "chat") ?>:</b></td>
+<tr valign="top">
+    <td align="right"><p><b><?php print_string("repeattimes", "chat") ?>:</b></td>
     <td><?php
        unset($options);
        $options[0]  = get_string("donotusechattime", "chat");
@@ -63,8 +63,8 @@
        choose_from_menu ($options, "schedule", $form->schedule, "", "", "");
     ?></td>
 </tr>
-<tr valign=top>
-       <td align=right><p><b><?php print_string("savemessages", "chat")?>:</b></p>
+<tr valign="top">
+       <td align="right"><p><b><?php print_string("savemessages", "chat")?>:</b></p>
        <td>
     <?php 
        unset($options);
@@ -85,8 +85,8 @@
     ?>
     </td>
 </tr>
-<tr valign=top>
-       <td align=right><p><b><?php print_string("studentseereports", "chat")?>:</b></p>
+<tr valign="top">
+       <td align="right"><p><b><?php print_string("studentseereports", "chat")?>:</b></p>
        <td>
     <?php 
        unset($options);
@@ -99,14 +99,14 @@
 
 </table>
 <center>
-<input type="hidden" name=course     value="<?php  p($form->course) ?>">
-<input type="hidden" name=coursemodule  value="<?php  p($form->coursemodule) ?>">
-<input type="hidden" name=section       value="<?php  p($form->section) ?>">
-<input type="hidden" name=module     value="<?php  p($form->module) ?>">
-<input type="hidden" name=modulename value="<?php  p($form->modulename) ?>">
-<input type="hidden" name=instance   value="<?php  p($form->instance) ?>">
-<input type="hidden" name=mode       value="<?php  p($form->mode) ?>">
+<input type="hidden" name="course"     value="<?php  p($form->course) ?>">
+<input type="hidden" name="coursemodule"  value="<?php  p($form->coursemodule) ?>">
+<input type="hidden" name="section"       value="<?php  p($form->section) ?>">
+<input type="hidden" name="module"     value="<?php  p($form->module) ?>">
+<input type="hidden" name="modulename" value="<?php  p($form->modulename) ?>">
+<input type="hidden" name="instance"   value="<?php  p($form->instance) ?>">
+<input type="hidden" name="mode"       value="<?php  p($form->mode) ?>">
 <input type="submit" value="<?php  print_string("savechanges") ?>">
-<input type="submit" name=cancel value="<?php  print_string("cancel") ?>">
+<input type="submit" name="cancel" value="<?php  print_string("cancel") ?>">
 </center>
 </form>

diff --git a/mod/chat/report.php b/mod/chat/report.php
index c58aca4f6cdcfda811b48e67ac06c86ba4af2361..0578d72e97ac10066a8a1e6c7ef33b459f8f20f6 100644 (file)
--- a/mod/chat/report.php
+++ b/mod/chat/report.php
@@ -1,4 +1,4 @@
-<?PHP  // $Id$
+<?php  // $Id$
 
 /// This page prints reports and info about chats
 

diff --git a/mod/chat/restorelib.php b/mod/chat/restorelib.php
index 0c0732eb32ac85f9b650856f9ad123383fa6dd3d..5500b5221497ed9e3b6a59cabcb78525a91e993a 100644 (file)
--- a/mod/chat/restorelib.php
+++ b/mod/chat/restorelib.php
@@ -1,4 +1,4 @@
-<?PHP //$Id$
+<?php //$Id$
     //This php script contains all the stuff to backup/restore
     //chat mods
 

diff --git a/mod/chat/users.php b/mod/chat/users.php
index e9f4d8fec4be13ec4d553ba2d084d01f9601ec60..48f8d779a2412888d3d141924e89e9aa0f7bbce1 100644 (file)
--- a/mod/chat/users.php
+++ b/mod/chat/users.php
@@ -66,7 +66,7 @@ header("Last-Modified: ".gmdate("D, d M Y H:i:s")." GMT");
 header("Cache-Control: no-cache, must-revalidate");
 header("Pragma: no-cache");
 header("Content-Type: text/html");
-header("Refresh: $CFG->chat_refresh_userlist; URL=users.php?chat_sid=$chat_sid&groupid=$groupid");
+header("Refresh: $CFG->chat_refresh_userlist; url=users.php?chat_sid=$chat_sid&groupid=$groupid");
 
 print_header();
 
@@ -94,11 +94,11 @@ if (!$chatusers = chat_get_users($chatuser->chatid, $groupid)) {
 echo "<table width=\"100%\">";
 foreach ($chatusers as $chatuser) {
     $lastping = $timenow - $chatuser->lastmessageping;
-    echo "<tr><td width=35>";
+    echo "<tr><td width=\"35\">";
     echo "<a target=\"_new\" onClick=\"return openpopup('/user/view.php?id=$chatuser->id&course=$chat->course','user$chatuser->id','');\" href=\"$CFG->wwwroot/user/view.php?id=$chatuser->id&course=$chat->course\">";
     print_user_picture($chatuser->id, 0, $chatuser->picture, false, false, false);
-    echo "</a></td><td valign=center>";
-    echo "<p><font size=1>";
+    echo "</a></td><td valign=\"center\">";
+    echo "<p><font size=\"1\">";
     echo fullname($chatuser)."<br />";
     echo "<font color=\"#888888\">$stridle: ".format_time($lastping, $str)."</font>";
     echo " <a href=\"users.php?chat_sid=$chat_sid&beep=$chatuser->id&groupid=$groupid\">$strbeep</a>";

diff --git a/mod/chat/version.php b/mod/chat/version.php
index 7a4579168e1409eb9ffea583848613740933fd32..f3bc17e9549afc09db324202b404afe777c02a42 100644 (file)
--- a/mod/chat/version.php
+++ b/mod/chat/version.php
@@ -1,4 +1,4 @@
-<?PHP // $Id$
+<?php // $Id$
 
 /////////////////////////////////////////////////////////////////////////////////
 ///  Code fragment to define the version of chat

diff --git a/mod/chat/view.php b/mod/chat/view.php
index e611f64c63951ba0269310737506aa1c9b6e8c24..b9cfe2d6415543fed480e444558e191474f044f4 100644 (file)
--- a/mod/chat/view.php
+++ b/mod/chat/view.php
@@ -1,4 +1,4 @@
-<?PHP  // $Id$
+<?php  // $Id$
 
 /// This page prints a particular instance of chat
 
@@ -51,12 +51,12 @@
     $strnextsession  = get_string("nextsession", "chat");
 
     print_header_simple("$chat->name", "",
-                 "<A HREF=index.php?id=$course->id>$strchats</A> -> $chat->name", 
+                 "<a href=\"index.php?id=$course->id\">$strchats</a> -> $chat->name", 
                   "", "", true, update_module_button($cm->id, $course->id, $strchat), 
                   navmenu($course, $cm));
 
     if (($chat->studentlogs or isteacher($course->id)) and !isguest()) {
-        echo "<p align=right><a href=\"report.php?id=$cm->id\">".
+        echo "<p align=\"right\"><a href=\"report.php?id=$cm->id\">".
               get_string("viewreport", "chat")."</a></p>";
     }
 
@@ -134,11 +134,11 @@
         echo "<table width=\"100%\">";
         foreach ($chatusers as $chatuser) {
             $lastping = $timenow - $chatuser->lastmessageping;
-            echo "<tr><td width=35>";
+            echo "<tr><td width=\"35\">";
             echo "<a href=\"$CFG->wwwroot/user/view.php?id=$chatuser->id&course=$chat->course\">";
             print_user_picture($chatuser->id, 0, $chatuser->picture, false, false, false);
-            echo "</a></td><td valign=center>";
-            echo "<p><font size=1>";
+            echo "</a></td><td valign=\"center\">";
+            echo "<p><font size=\"1\">";
             echo fullname($chatuser).'<br />';
             echo "<font color=\"#888888\">$stridle: ".format_time($lastping)."</font>";
             echo "</font></p>";

diff --git a/mod/choice/backuplib.php b/mod/choice/backuplib.php
index a3d3115c39f66cc3e11fd6498a39f3badb2b070b..c4d59067c4d32b8296dc77ad1ae43967d1641a0d 100644 (file)
--- a/mod/choice/backuplib.php
+++ b/mod/choice/backuplib.php
@@ -1,4 +1,4 @@
-<?PHP //$Id$
+<?php //$Id$
     //This php script contains all the stuff to backup/restore
     //choice mods
 

diff --git a/mod/choice/db/mysql.php b/mod/choice/db/mysql.php
index cb9d2863d73845d769836a597c7c49410a26edf9..5a5449d04b6dd158f26d0fd80721fad51b4d251c 100644 (file)
--- a/mod/choice/db/mysql.php
+++ b/mod/choice/db/mysql.php
@@ -1,4 +1,4 @@
-<?PHP // $Id$
+<?php // $Id$
 
 function choice_upgrade($oldversion) {
 // This function does anything necessary to upgrade

diff --git a/mod/choice/db/oci8po.php b/mod/choice/db/oci8po.php
index 75bf1f2c76d80a526bcc60af3c022f7f4c2a8f47..70ad03e55c1445f7e79bcb4791b9258cf91eab7d 100755 (executable)
--- a/mod/choice/db/oci8po.php
+++ b/mod/choice/db/oci8po.php
@@ -1,4 +1,4 @@
-<?PHP 
+<?php 
 
 function choice_upgrade($oldversion) {
 // This function does anything necessary to upgrade

diff --git a/mod/choice/db/postgres7.php b/mod/choice/db/postgres7.php
index 1d4062fc63cd4de1bfa5e96596dca80f08bfdfeb..75440914f50186c0e4a6b7ed5ffdc7e80c383be6 100644 (file)
--- a/mod/choice/db/postgres7.php
+++ b/mod/choice/db/postgres7.php
@@ -1,4 +1,4 @@
-<?PHP // $Id$
+<?php // $Id$
 
 function choice_upgrade($oldversion) {
 // This function does anything necessary to upgrade

diff --git a/mod/choice/index.php b/mod/choice/index.php
index a90f67f371be03388ba73e25ebf0c0aada3eb31e..aafcbb2f61cb8cc2e93947b8bfbf6ddc7d90a27e 100644 (file)
--- a/mod/choice/index.php
+++ b/mod/choice/index.php
@@ -1,4 +1,4 @@
-<?PHP  // $Id$
+<?php  // $Id$
 
     require_once("../../config.php");
     require_once("lib.php");

diff --git a/mod/choice/lib.php b/mod/choice/lib.php
index 73c8e21f9351024e2727fb96d9d750b04187aa62..aa536c8019024e291a0bba333b93971dc0edd843 100644 (file)
--- a/mod/choice/lib.php
+++ b/mod/choice/lib.php
@@ -1,4 +1,4 @@
-<?PHP // $Id$
+<?php // $Id$
 
 $CHOICE_MAX_NUMBER = 6;
 

diff --git a/mod/choice/mod.html b/mod/choice/mod.html
index f69d662eb0b0ab01496b4656b145574dc18bb7d0..6ee2a07803c3f7a810da782fef3985d700fe8b52 100644 (file)
--- a/mod/choice/mod.html
+++ b/mod/choice/mod.html
@@ -51,17 +51,17 @@
 ?>
 <form name="form" method="post" action="mod.php">
 
-<table cellpadding=5>
+<table cellpadding="5">
 
-<tr valign=top>
-    <td align=right><p><b><?php print_string("choicename","choice") ?>:</b></p></td>
+<tr valign="top">
+    <td align="right"><p><b><?php print_string("choicename","choice") ?>:</b></p></td>
     <td>
-        <input type="text" name="name" size=30 value="<?php p($form->name) ?>">
+        <input type="text" name="name" size="30" value="<?php p($form->name) ?>">
     </td>
 </tr>
 
-<tr valign=top>
-    <td align=right><p><b><?php print_string("choicetext","choice") ?>:</b></p>
+<tr valign="top">
+    <td align="right"><p><b><?php print_string("choicetext","choice") ?>:</b></p>
     <font size="1">
      <?php
         helpbutton("writing", get_string("helpwriting"), "moodle", true, true);
@@ -84,7 +84,7 @@
        if ($usehtmleditor) {
            echo '<input type="hidden" name="format" value="'.FORMAT_HTML.'" />';
        } else {
-           echo "<p align=right>";
+           echo "<p align=\"right\">";
            helpbutton("textformat", get_string("formattexttype"));
            print_string("formattexttype");
            echo ":&nbsp;";
@@ -98,53 +98,53 @@
     </td>
 </tr>
 
-<tr valign=top>
-    <td align=right><p><b><?php print_string("choice","choice","1") ?>:</b></p></td>
+<tr valign="top">
+    <td align="right"><p><b><?php print_string("choice","choice","1") ?>:</b></p></td>
     <td>
-        <input type="text" name="answer1" size=60 value="<?php p($form->answer1) ?>">
+        <input type="text" name="answer1" size="60" value="<?php p($form->answer1) ?>">
         <?php helpbutton("options", get_string("modulenameplural", "choice"), "choice") ?>
     </td>
 </tr>
 
-<tr valign=top>
-    <td align=right><p><b><?php print_string("choice","choice","2") ?>:</b></p></td>
+<tr valign="top">
+    <td align="right"><p><b><?php print_string("choice","choice","2") ?>:</b></p></td>
     <td>
-        <input type="text" name="answer2" size=60 value="<?php p($form->answer2) ?>">
+        <input type="text" name="answer2" size="60" value="<?php p($form->answer2) ?>">
         <?php helpbutton("options", get_string("modulenameplural", "choice"), "choice") ?>
     </td>
 </tr>
 
-<tr valign=top>
-    <td align=right><p><b><?php print_string("choice","choice","3") ?>:</b></p></td>
+<tr valign="top">
+    <td align="right"><p><b><?php print_string("choice","choice","3") ?>:</b></p></td>
     <td>
-        <input type="text" name="answer3" size=60 value="<?php p($form->answer3) ?>">
+        <input type="text" name="answer3" size="60" value="<?php p($form->answer3) ?>">
         <?php helpbutton("options", get_string("modulenameplural", "choice"), "choice") ?>
     </td>
 </tr>
-<tr valign=top>
-    <td align=right><p><b><?php print_string("choice","choice","4") ?>:</b></p></td>
+<tr valign="top">
+    <td align="right"><p><b><?php print_string("choice","choice","4") ?>:</b></p></td>
     <td>
-        <input type="text" name="answer4" size=60 value="<?php p($form->answer4) ?>">
+        <input type="text" name="answer4" size="60" value="<?php p($form->answer4) ?>">
         <?php helpbutton("options", get_string("modulenameplural", "choice"), "choice") ?>
     </td>
 </tr>
-<tr valign=top>
-    <td align=right><p><b><?php print_string("choice","choice","5") ?>:</b></p></td>
+<tr valign="top">
+    <td align="right"><p><b><?php print_string("choice","choice","5") ?>:</b></p></td>
     <td>
-        <input type="text" name="answer5" size=60 value="<?php p($form->answer5) ?>">
+        <input type="text" name="answer5" size="60" value="<?php p($form->answer5) ?>">
         <?php helpbutton("options", get_string("modulenameplural", "choice"), "choice") ?>
     </td>
 </tr>
-<tr valign=top>
-    <td align=right><p><b><?php print_string("choice","choice","6") ?>:</b></p></td>
+<tr valign="top">
+    <td align="right"><p><b><?php print_string("choice","choice","6") ?>:</b></p></td>
     <td>
-        <input type="text" name="answer6" size=60 value="<?php p($form->answer6) ?>">
+        <input type="text" name="answer6" size="60" value="<?php p($form->answer6) ?>">
         <?php helpbutton("options", get_string("modulenameplural", "choice"), "choice") ?>
     </td>
 </tr>
 
-<tr valign=top>
-    <td align=right><p><b><?php print_string("timerestrict", "choice") ?>:</b></p></td>
+<tr valign="top">
+    <td align="right"><p><b><?php print_string("timerestrict", "choice") ?>:</b></p></td>
     <td>
         <script>
             var timeitems = ['openday','openmonth','openyear','openhour', 'openminute', 'closeday','closemonth','closeyear','closehour','closeminute'];
@@ -156,7 +156,7 @@
      ?>
     </td>
 </tr>
-<tr valign=top>
+<tr valign="top">
     <td><p>&nbsp;</p></td>
     <td>
 
@@ -181,7 +181,7 @@
                 </td>
             </tr>
             <tr>
-                <td align=right><p><b><?php print_string("choiceclose", "choice") ?>:</b></p></td>
+                <td align="right"><p><b><?php print_string("choiceclose", "choice") ?>:</b></p></td>
                 <td>
                 
     <?php
@@ -213,8 +213,8 @@
     </td>
 </tr>
 
-<tr valign=top>
-    <td align=right><P><B><?php print_string("publish","choice") ?>:</b></p></td>
+<tr valign="top">
+    <td align="right"><p><b><?php print_string("publish","choice") ?>:</b></p></td>
     <td>
         <?php
         require_once("$CFG->dirroot/mod/choice/lib.php");
@@ -224,8 +224,8 @@
     </td>
 </tr>
 
-<tr valign=top>
-    <td align=right><P><B><?php print_string("privacy","choice") ?>:</b></p></td>
+<tr valign="top">
+    <td align="right"><p><b><?php print_string("privacy","choice") ?>:</b></p></td>
     <td>
         <?php
         require_once("$CFG->dirroot/mod/choice/lib.php");
@@ -236,8 +236,8 @@
 </tr>
 
 
-<tr valign=top>
-    <td align=right><P><B><?php print_string("allowupdate","choice") ?>:</b></p></td>
+<tr valign="top">
+    <td align="right"><p><b><?php print_string("allowupdate","choice") ?>:</b></p></td>
     <td>
         <?php
         $options[0] = get_string("no");
@@ -249,8 +249,8 @@
 </tr>
 
 
-<tr valign=top>
-    <td align=right><P><B><?php print_string("showunanswered","choice") ?>:</b></p></td>
+<tr valign="top">
+    <td align="right"><p><b><?php print_string("showunanswered","choice") ?>:</b></p></td>
     <td>
         <?php
         $options[0] = get_string("no");
@@ -264,14 +264,14 @@
 </table>
 
 <center>
-<input type="hidden" name=course     value="<?php p($form->course) ?>">
-<input type="hidden" name=coursemodule  value="<?php p($form->coursemodule) ?>">
-<input type="hidden" name=section       value="<?php p($form->section) ?>">
-<input type="hidden" name=module     value="<?php p($form->module) ?>">
-<input type="hidden" name=modulename value="<?php p($form->modulename) ?>">
-<input type="hidden" name=instance   value="<?php p($form->instance) ?>">
-<input type="hidden" name=mode       value="<?php p($form->mode) ?>">
+<input type="hidden" name="course"     value="<?php p($form->course) ?>">
+<input type="hidden" name="coursemodule"  value="<?php p($form->coursemodule) ?>">
+<input type="hidden" name="section"       value="<?php p($form->section) ?>">
+<input type="hidden" name="module"     value="<?php p($form->module) ?>">
+<input type="hidden" name="modulename" value="<?php p($form->modulename) ?>">
+<input type="hidden" name="instance"   value="<?php p($form->instance) ?>">
+<input type="hidden" name="mode"       value="<?php p($form->mode) ?>">
 <input type="submit" value="<?php print_string("savechanges") ?>">
-<input type="submit" name=cancel value="<?php print_string("cancel") ?>">
+<input type="submit" name="cancel" value="<?php print_string("cancel") ?>">
 </center>
 </form>

diff --git a/mod/choice/report.php b/mod/choice/report.php
index 1f77f531cef1d605b0b727272a4996aebbaa13a2..d5f5c33e100a0c7ab49d2932aabf373aee532bd7 100644 (file)
--- a/mod/choice/report.php
+++ b/mod/choice/report.php
@@ -1,4 +1,4 @@
-<?PHP  // $Id$
+<?php  // $Id$
 
     require_once("../../config.php");
     require_once("lib.php");
@@ -97,9 +97,9 @@
 
     foreach ($useranswer as $key => $answer) {
         if ($key) {
-            echo "<td width=\"$tablewidth%\" valign=top nowrap bgcolor=\"$THEME->cellcontent\">";
+            echo "<td width=\"$tablewidth%\" valign=\"top\" nowrap bgcolor=\"$THEME->cellcontent\">";
         } else {
-            echo "<td width=\"$tablewidth%\" valign=top nowrap bgcolor=\"$THEME->body\">";
+            echo "<td width=\"$tablewidth%\" valign=\"top\" nowrap bgcolor=\"$THEME->body\">";
         }
 
         echo "<table width=\"100%\">";

diff --git a/mod/choice/restorelib.php b/mod/choice/restorelib.php
index 22b5fd08a3d2304f02340d792ba0418a78e64a2f..c40ba25b3a0505f00d6efdafbf7a56522f2d4490 100644 (file)
--- a/mod/choice/restorelib.php
+++ b/mod/choice/restorelib.php
@@ -1,4 +1,4 @@
-<?PHP //$Id$
+<?php //$Id$
     //This php script contains all the stuff to backup/restore
     //choice mods
 

diff --git a/mod/choice/version.php b/mod/choice/version.php
index 2a4e52d335345356da41b55e8be147386d01e47a..29f584bf035c3e4b25adec571a72a14cde873e7b 100644 (file)
--- a/mod/choice/version.php
+++ b/mod/choice/version.php
@@ -1,4 +1,4 @@
-<?PHP // $Id$
+<?php // $Id$
 
 ////////////////////////////////////////////////////////////////////////////////
 //  Code fragment to define the module version etc.

diff --git a/mod/choice/view.php b/mod/choice/view.php
index 5f241a7a895a8261ef1ccc7a2d7d2a281f4bb4d0..77f4ef1fd4f488307feddf2f12b682d280fcc6cc 100644 (file)
--- a/mod/choice/view.php
+++ b/mod/choice/view.php
@@ -1,4 +1,4 @@
-<?PHP  // $Id$
+<?php  // $Id$
 
     require_once("../../config.php");
     require_once("lib.php");
@@ -64,7 +64,7 @@
     add_to_log($course->id, "choice", "view", "view.php?id=$cm->id", $choice->id, $cm->id);
 
     print_header_simple("$choice->name", "",
-                 "<A HREF=index.php?id=$course->id>$strchoices</A> -> $choice->name", "", "", true,
+                 "<a href=\"index.php?id=$course->id\">$strchoices</a> -> $choice->name", "", "", true,
                   update_module_button($cm->id, $course->id, $strchoice), navmenu($course, $cm));
 
 /// Check to see if groups are being used in this choice
@@ -80,7 +80,7 @@
         } else {
             $responsecount = 0;
         }
-        echo "<P align=right><A HREF=\"report.php?id=$cm->id\">".get_string("viewallresponses", "choice", $responsecount)."</A></P>";
+        echo "<p align=\"right\"><a href=\"report.php?id=$cm->id\">".get_string("viewallresponses", "choice", $responsecount)."</a></p>";
     } else if (!$cm->visible) {
         notice(get_string("activityiscurrentlyhidden"));
     }
@@ -99,26 +99,26 @@
     if ( (!$current or $choice->allowupdate) and ($choice->timeclose >= time() or $choice->timeclose == 0) ) { 
     // They haven't made their choice yet or updates allowed and choice is open
     
-        echo "<CENTER><P><FORM name=\"form\" method=\"post\" action=\"view.php\">";
-        echo "<TABLE CELLPADDING=20 CELLSPACING=20><TR>";
+        echo "<center><p><form name=\"form\" method=\"post\" action=\"view.php\">";
+        echo "<table cellpadding=\"20\" cellspacing=\"20\"><tr>";
 
         foreach ($choice->answer as $key => $answer) {
             if ($answer) {
-                echo "<TD ALIGN=CENTER>";
-                echo "<INPUT type=radio name=answer value=\"$key\" ".$answerchecked[$key]." />";
+                echo "<td align=\"center\">";
+                echo "<input type=\"radio\" name=\"answer\" value=\"$key\" ".$answerchecked[$key]." />";
                 p($answer);
-                echo "</TD>";
+                echo "</td>";
             }
         }
     
-        echo "</TR></TABLE>";
-        echo "<INPUT type=hidden name=id value=\"$cm->id\" />";
+        echo "</tr></table>";
+        echo "<input type=\"hidden\" name=\"id\" value=\"$cm->id\" />";
         if (isstudent($course->id) or isteacher($course->id, 0, false)) {
-            echo "<INPUT type=submit value=\"".get_string("savemychoice","choice")."\" />";
+            echo "<input type=\"submit\" value=\"".get_string("savemychoice","choice")."\" />";
         } else {
             print_string('havetologin', 'choice');
         }
-        echo "</P></FORM></CENTER>";
+        echo "</p></form></center>";
 
     }
 
@@ -179,7 +179,7 @@
 
             $tablewidth = (int) (100.0 / count($useranswer));
 
-            echo "<table cellpadding=5 cellspacing=10 align=center>";
+            echo "<table cellpadding=\"5\" cellspacing=\"10\" align=\"center\">";
             echo "<tr>";
             foreach ($useranswer as $key => $answer) {
                 if ($key) {
@@ -196,18 +196,18 @@
         
             foreach ($useranswer as $key => $answer) {
                 if ($key) {
-                    echo "<td width=\"$tablewidth%\" valign=top nowrap bgcolor=\"$THEME->cellcontent\">";
+                    echo "<td width=\"$tablewidth%\" valign=\"top\" nowrap bgcolor=\"$THEME->cellcontent\">";
                 } else if ($choice->showunanswered) {
-                    echo "<td width=\"$tablewidth%\" valign=top nowrap bgcolor=\"$THEME->body\">";
+                    echo "<td width=\"$tablewidth%\" valign=\"top\" nowrap bgcolor=\"$THEME->body\">";
                 } else {
                     continue;
                 }
     
-                echo "<table width=100%>";
+                echo "<table width=\"100%\">";
                 foreach ($answer as $user) {
-                    echo "<tr><td width=10 nowrap>";
+                    echo "<tr><td width=\"10\" nowrap>";
                     print_user_picture($user->id, $course->id, $user->picture);
-                    echo "</td><td width=100% nowrap>";
+                    echo "</td><td width=\"100%\" nowrap>";
                     echo "<p>".fullname($user, $isteacher)."</p>";
                     echo "</td></tr>";
                 }
@@ -222,7 +222,7 @@
           case CHOICE_PUBLISH_ANONYMOUS:
             $tablewidth = (int) (100.0 / count($useranswer));
 
-            echo "<table cellpadding=5 cellspacing=10 align=center>";
+            echo "<table cellpadding=\"5\" cellspacing=\"10\" align=\"center\">";
             echo "<tr>";
             foreach ($useranswer as $key => $answer) {
                 if ($key) {