ensure that layout table headers are not marked as th, but by label instead MDL-7438

th should be used only for data tables

diff --git a/admin/langimport.php b/admin/langimport.php
index 061cfde34f489f46a77448e3f06084a5a2326b1c..7eeb673d23c88db3a5e96dee2170e302369fb337 100755 (executable)
--- a/admin/langimport.php
+++ b/admin/langimport.php
@@ -244,11 +244,11 @@
             }
             
             print_simple_box_start('center','60%');
-            echo '<table width="100%"><tr><th align="center">';
-            echo get_string('installedlangs','admin');
-            echo '</th><th align="center">';
-            echo get_string('availablelangs','admin');
-            echo '</th></tr>';
+            echo '<table width="100%"><tr><td align="center">';
+            echo '<label for="uninstalllang">'.get_string('installedlangs','admin').'</label>';
+            echo '</td><td align="center">';
+            echo '<label for="pack">'.get_string('availablelangs','admin').'</label>';
+            echo '</td></tr>';
             echo '<tr><td align="center" valign="top">';
             echo '<form name="uninstallform" action="langimport.php?mode=4" method="POST">';
             echo '<input name="sesskey" type="hidden" value="'.sesskey().'" />';
@@ -257,7 +257,7 @@
 
             /// display installed langs here
 
-            echo '<select name="uninstalllang" size="15">';
+            echo '<select name="uninstalllang" id="uninstalllang" size="15">';
             foreach ($installedlangs as $clang =>$ilang){
                 echo '<option value="'.$clang.'">'.$ilang.'</option>';
             }
@@ -301,7 +301,7 @@
             echo '<form name="installform" method="POST" action="langimport.php?mode=2">';
             echo '<input name="sesskey" type="hidden" value="'.sesskey().'" />';
             if ($remote) {
-                echo '<select name="pack" size="15">';
+                echo '<select name="pack" id="pack" size="15">';
             }
 
             foreach ($availablelangs as $alang) {

diff --git a/blog/tags.html b/blog/tags.html
index 56ef37c0878b34b13a52b6f10374e328b4f1f119..9764da10aa95c6b855d95e9d14cb191ab5f9f737 100755 (executable)
--- a/blog/tags.html
+++ b/blog/tags.html
@@ -8,8 +8,8 @@ print_heading(get_string('tagmanagement'));
 
 <table>
     <tr>
-        <th width="50%" align="left"><?php print_string('otags','blog');?></th>
-        <th width="50%" align="left"><?php print_string('ptags','blog');?></th>
+        <td width="50%" align="left"><label for="otags"><?php print_string('otags','blog');?></label></td>
+        <td width="50%" align="left"><label for="ptags"><?php print_string('ptags','blog');?></label></td>
     </tr>
 
     <tr>
@@ -19,7 +19,7 @@ print_heading(get_string('tagmanagement'));
             <?php
             if (has_capability('moodle/blog:manageofficialtags', $sitecontext)) {
             ?>
-            <select name="tags[]" multiple="multiple" size="8">
+            <select name="tags[]" id="otags" multiple="multiple" size="8">
             <?php
                 foreach ($otags as $otag) {
                     echo '<option value="'.$otag->id.'">'.$otag->text.'</option>';
@@ -44,7 +44,7 @@ print_heading(get_string('tagmanagement'));
         <td>
             <form action="tags.php" method="POST">
             <input type="hidden" name="sesskey" value="<?php echo sesskey(); ?>" />
-            <select name="tags[]" multiple="multiple" size="8">
+            <select name="tags[]" multiple="multiple" id="ptags" size="8">
             <?php
 
                 $ptags = array();

diff --git a/course/groups-edit.html b/course/groups-edit.html
index ed0cf2a0e97130e13586b52af1115c448f18a93c..f41852bd01f13c328211f0852f38bb3ffc74f90e 100755 (executable)
--- a/course/groups-edit.html
+++ b/course/groups-edit.html
@@ -88,9 +88,9 @@ function groupWindow(selectgroup) {
 
   <table cellspacing="0" cellpadding="10" align="center" class="generaltable generalbox">
     <tr>
-      <th width="33%" align="center" class="header"><?php p($strmemberincourse) ?></td>
-      <th width="33%" align="center" class="header"><?php p($strgroups) ?></td>
-      <th width="33%" align="center" class="header"><?php p($strgroupmembersselected) ?></td>
+      <td width="33%" align="center" class="header"><label for="nonmembers"><?php p($strmemberincourse) ?></label></td>
+      <td width="33%" align="center" class="header"><label for="groups"><?php p($strgroups) ?></label></td>
+      <td width="33%" align="center" class="header"><label for="members"><?php p($strgroupmembersselected) ?></label></td>
     </tr>
     <tr align="center" valign="top">
       <td class="generalboxcontent"><p>
@@ -100,7 +100,7 @@ function groupWindow(selectgroup) {
           <input type="hidden" name="sesskey" value="<?php p($sesskey) ?>">
           <input type="hidden" name="roleid" value="<?php p($roleid) ?>">
           
-          <select name="nonmembers[]" size="15" multiple="multiple">
+          <select name="nonmembers[]" size="15" id="nonmembers" multiple="multiple">
             <?php 
                 if (!empty($nonmembers)) {
                     foreach ($nonmembers as $id => $nonmembername) {
@@ -134,7 +134,7 @@ function groupWindow(selectgroup) {
           <input type="hidden" name="id" value="<?php p($course->id) ?>" />
           <input type="hidden" name="sesskey" value="<?php p($sesskey) ?>">
           <input type="hidden" name="roleid" value="<?php p($roleid) ?>">
-          <select name="groups" size="15" onChange="updateMembers(this)">
+          <select name="groups" size="15" id="groups" onChange="updateMembers(this)">
             <?php 
                 if (!empty($listgroups)) {
                     foreach ($listgroups as $id => $listgroup) {
@@ -169,7 +169,7 @@ function groupWindow(selectgroup) {
           <input type="hidden" name="groupid" value="<?php p($selectedgroup) ?>" />
           <input type="hidden" name="sesskey" value="<?php p($sesskey) ?>">
           <input type="hidden" name="roleid" value="<?php p($roleid) ?>">
-          <select name="members[]" size="15" multiple="multiple">
+          <select name="members[]" size="15" id="members" multiple="multiple">
             <?php 
                 if (!empty($members)) {
                     foreach ($members as $id => $membername) {

diff --git a/course/importstudents.html b/course/importstudents.html
index 7c3c198b6f97f27f57cea94313583a00069f8a32..ac3afd1779ed3b9d0047cdf06b9d2e340502b9ca 100644 (file)
--- a/course/importstudents.html
+++ b/course/importstudents.html
@@ -5,13 +5,13 @@
 <input type="hidden" name="id" value="<?php echo $id?>">
   <table align="center" border="0" cellpadding="5" cellspacing="0">
     <tr>
-      <th valign="top">
-          <?php echo count($alreadycourses) . " ". $stralreadycourses ?>
-      </th>
-      <th></th>
-      <th valign="top">
-          <?php echo $numcourses . " " . $strpotentialcourses ?>
-      </th>
+      <td valign="top">
+          <label for="removeselect"><?php echo count($alreadycourses) . " ". $stralreadycourses ?></label>
+      </td>
+      <td></td>
+      <td valign="top">
+          <label for="addselect"><?php echo $numcourses . " " . $strpotentialcourses ?></label>
+      </td>
     </tr>
     <tr>
       <td valign="top">