MDL-14591 - recover gracefully from portfolio cron

diff --git a/lib/portfoliolib.php b/lib/portfoliolib.php
index 2304d7a16697c975b941bab7b4564788844e6639..6850cd35baa3d2c08fe453aca579c163c6bccb69 100644 (file)
--- a/lib/portfoliolib.php
+++ b/lib/portfoliolib.php
@@ -798,8 +798,12 @@ function portfolio_cron() {
 
     if ($expired = $DB->get_records_select('portfolio_tempdata', 'expirytime < ?', array(time()), '', 'id')) {
         foreach ($expired as $d) {
-            $e = portfolio_exporter::rewaken_object($d);
-            $e->process_stage_cleanup(true);
+            try {
+                $e = portfolio_exporter::rewaken_object($d->id);
+                $e->process_stage_cleanup(true);
+            } catch (Exception $e) {
+                mtrade('Exception thrown in portfolio cron while cleaning up ' . $d->id . ': ' . $e->getMessage());
+            }
         }
     }
 }