MDL-18948 fixed handling of indexes when removing options; merged from MOODLE_19_STABLE

diff --git a/lib/form/select.php b/lib/form/select.php
index 95a1fb4fe40d802e60ce266ad559bbcdd3f65340..6dfff5fede433fb78d78a2201d31d9b801e3ae93 100644 (file)
--- a/lib/form/select.php
+++ b/lib/form/select.php
@@ -92,6 +92,8 @@ class MoodleQuickForm_select extends HTML_QuickForm_select{
         foreach ($this->_options as $key=>$option){
             if ($option['attr']['value']==$value){
                 unset($this->_options[$key]);
+                // we must reindex the options because the ugly code in quickforms' select.php expects that keys are 0,1,2,3... !?!?
+                $this->_options = array_merge($this->_options);
                 return;
             }
         }