MDL-8096 - fixed set_user_preference() weirdness, you could not pass $USER->id as...

diff --git a/lib/moodlelib.php b/lib/moodlelib.php
index a6cb7004e8cc2f6a3c86632034d1b32860b3720f..b2416c670b7f7b0d69c02c0a7e1bfbbf27f86a60 100644 (file)
--- a/lib/moodlelib.php
+++ b/lib/moodlelib.php
@@ -736,7 +736,7 @@ function set_user_preference($name, $value, $otheruser=NULL) {
 
     if ($preference = get_record('user_preferences', 'userid', $userid, 'name', $name)) {
         if (set_field('user_preferences', 'value', $value, 'id', $preference->id)) {
-            if (empty($otheruser) and !empty($USER)) {
+            if ($userid == $USER->id) {
                 $USER->preference[$name] = $value;
             }
             return true;
@@ -749,7 +749,7 @@ function set_user_preference($name, $value, $otheruser=NULL) {
         $preference->name   = $name;
         $preference->value  = (string)$value;
         if (insert_record('user_preferences', $preference)) {
-            if (empty($otheruser) and !empty($USER)) {
+            if ($userid == $USER->id) {
                 $USER->preference[$name] = $value;
             }
             return true;