MDL-16362 "Quiz - bar graph on results screen" there was a bug in my code that would...

diff --git a/mod/quiz/report/overview/report.php b/mod/quiz/report/overview/report.php
index d82e4f8c4844b5baf33983c4adf7df4cb66643c0..db309082baf9fca1d80c7ad28cb80492ad421ab8 100644 (file)
--- a/mod/quiz/report/overview/report.php
+++ b/mod/quiz/report/overview/report.php
@@ -29,8 +29,10 @@ class quiz_overview_report extends quiz_default_report {
         $fakeattempt->timefinish = $quiz->timeopen;
         $fakeattempt->userid = 0;
         $reviewoptions = quiz_get_reviewoptions($quiz, $fakeattempt, $this->context);
-        $showgrades = $quiz->grade && $quiz->sumgrades && $reviewoptions->scores;
-
+        $showgrades = ($quiz->grade  !== 0) && ($quiz->sumgrades !== 0) && $reviewoptions->scores;
+        echo '<pre>';
+        var_dump(compact('showgrades', 'quiz'));
+        echo '</pre>';
         $download = optional_param('download', '', PARAM_ALPHA);
         
         /// find out current groups mode
@@ -207,9 +209,6 @@ class quiz_overview_report extends quiz_default_report {
         if (!$nostudents || ($attemptsmode == QUIZ_REPORT_ATTEMPTS_ALL)){
     
     
-            $showgrades = $quiz->grade && $quiz->sumgrades && $reviewoptions->scores;
-            $hasfeedback = quiz_has_feedback($quiz->id) && $quiz->grade > 1.e-7 && $quiz->sumgrades > 1.e-7;
-    
     
             // Construct the SQL
             $fields = $DB->sql_concat('u.id', '\'#\'', 'COALESCE(qa.attempt, \'0\')').' AS uniqueid, ';