Merged from MOODLE_19_STABLE: MDL-13161 - auth/db - suppress php warning when there...

diff --git a/auth/db/auth.php b/auth/db/auth.php
index 2da10f05bf9cf002d133863571e57a917cc5a513..239df97e147b8ec605d47c7a17c3aaaac8bf8a67 100644 (file)
--- a/auth/db/auth.php
+++ b/auth/db/auth.php
@@ -334,10 +334,12 @@ class auth_plugin_db extends auth_plugin_base {
 
         // simplify down to usernames
         $usernames = array();
-        foreach ($users as $user) {
-            array_push($usernames, $user->username);
+        if (!empty($users)) {
+            foreach ($users as $user) {
+                array_push($usernames, $user->username);
+            }
+            unset($users);
         }
-        unset($users);
 
         $add_users = array_diff($userlist, $usernames);
         unset($usernames);