Fixed redirection when user not completed yet in some instances when

using external authentication

diff --git a/lib/moodlelib.php b/lib/moodlelib.php
index 7d96ddd0b36fd6290d9646f3a31250d6667e0f73..7c30e73e8a367019c2b252f619f76d4360dfc442 100644 (file)
--- a/lib/moodlelib.php
+++ b/lib/moodlelib.php
@@ -301,11 +301,6 @@ function require_login($courseid=0) {
             } else {  // just update their last login time
                 update_user_in_db();
             }
-            if (!$USER->email) {            // User logged in, but has not set up profile!
-                                            // This can occur with external authentication
-                redirect("$CFG->wwwroot/user/edit.php?id=$USER->id&course=$courseid");
-                die;
-            }
             return;   // user is a member of this course.
         }
         if (! $course = get_record("course", "id", $courseid)) {

diff --git a/user/edit.php b/user/edit.php
index 27a43bee595808fad0bcfed218067187ff1afa4f..044e43c3e961777e3c95fa8ccc6cc87e64c32840 100644 (file)
--- a/user/edit.php
+++ b/user/edit.php
@@ -15,7 +15,7 @@
         error("Course ID was incorrect");
     }
 
-    if ($user->confirmed and !$user->email) {
+    if ($user->confirmed and user_not_fully_set_up($user)) {
         // Special case which can only occur when a new account 
         // has just been created by EXTERNAL authentication
         // This is the only page in Moodle that has the exception