mod/assignment: Remove SQL "id,id" which causes errors on Oracle - MDL-12425

This loop also needs some rewriting - it is _very_ inefficient on
large courses.

diff --git a/mod/assignment/lib.php b/mod/assignment/lib.php
index 07d9d7fcdb80dbb8c5169d70d4e457320be1a271..d29175d6768ee1211883bccc8afa46dd71f5b5dc 100644 (file)
--- a/mod/assignment/lib.php
+++ b/mod/assignment/lib.php
@@ -2750,8 +2750,8 @@ function assignment_print_overview($courses, &$htmlarray) {
             $submissions = 0; // init
             if ($students = get_users_by_capability($context, 'mod/assignment:submit', '', '', '', '', 0, '', false)) {
                  foreach ($students as $student) {
-                    if (get_records_sql("SELECT id,id FROM {$CFG->prefix}assignment_submissions
-                                         WHERE assignment = $assignment->id AND
+                    if (record_exists_sql("SELECT id FROM {$CFG->prefix}assignment_submissions
+                                           WHERE assignment = $assignment->id AND
                                                userid = $student->id AND
                                                teacher = 0 AND
                                                timemarked = 0")) {