Minor improvement to validation code. Merged from MOODLE_18_STABLE.

diff --git a/question/type/shortanswer/edit_shortanswer_form.php b/question/type/shortanswer/edit_shortanswer_form.php
index 54b9e6f9dffbc41aaca0a1c96a819478eca714a9..776f9e0ff7361d9da80f1c8784e9eb56f5f64b0e 100644 (file)
--- a/question/type/shortanswer/edit_shortanswer_form.php
+++ b/question/type/shortanswer/edit_shortanswer_form.php
@@ -68,13 +68,10 @@ class question_edit_shortanswer_form extends question_edit_form {
         $answers = $data['answer'];
         $answercount = 0;
         $maxgrade = false;
-        foreach ($answers as $key => $answer){
+        foreach ($answers as $key => $answer) {
             $trimmedanswer = trim($answer);
             if (!empty($trimmedanswer)){
                 $answercount++;
-            }
-            // Check grades
-            if ($answer != '') {
                 if ($data['fraction'][$key] == 1) {
                     $maxgrade = true;
                 }