modfeedback MDL-16706 Removed inline scripts in mod feedback and added feedback.js

diff --git a/mod/feedback/edit_item.php b/mod/feedback/edit_item.php
index f2e4000499b7ba7f41b62bf48dffc07c9ef45f48..111e8b0e0861db87459925c6889d031f0c121a67 100644 (file)
--- a/mod/feedback/edit_item.php
+++ b/mod/feedback/edit_item.php
@@ -228,14 +228,8 @@
     // print_box_end();
   
     if ($typ!='label') {
-        echo <<<EOD
-        <script language="javascript">
-        var item = document.getElementById("id_itemname");
-        if(item){
-            item.focus();
-        }
-        </script>
-EOD;
+        $PAGE->requires->js('mod/feedback/feedback.js');
+        $PAGE->requires->js_function_call('set_item_focus', Array('id_itemname'));
     } 
 
     /// Finish the page

diff --git a/mod/feedback/feedback.js b/mod/feedback/feedback.js
new file mode 100644 (file)
index 0000000..2bb1b6d
--- /dev/null
+++ b/mod/feedback/feedback.js
@@ -0,0 +1,11 @@
+function set_item_focus(itemid) {
+    var item = document.getElementById(itemid);
+    if(item){
+        item.focus();
+    }
+}
+
+function feedbackGo2delete(form) {
+    form.action = moodle_cfg.wwwroot+'/mod/feedback/delete_completed.php';
+    form.submit();
+}
\ No newline at end of file

diff --git a/mod/feedback/show_entries_anonym.php b/mod/feedback/show_entries_anonym.php
index 228db2ec01f4f16cf22f026b317400909416e4c2..0837d964519b42daf01d67f1b740e43cc81f2133 100644 (file)
--- a/mod/feedback/show_entries_anonym.php
+++ b/mod/feedback/show_entries_anonym.php
@@ -84,15 +84,8 @@
     //print the list with anonymous completeds
     // print_simple_box_start("center");
     print_box_start('generalbox boxaligncenter boxwidthwide');
+    $PAGE->requires->js('mod/feedback/feedback.js');
 ?>
-    <script type="text/javascript">
-        function feedbackGo2delete(form)
-        {
-            form.action = "<?php echo $CFG->wwwroot;?>/mod/feedback/delete_completed.php";
-            form.submit();
-        }
-    </script>
-
     <div class="mdl-align">
     <form name="frm" action="<?php echo me();?>" method="post">
         <table>