question bank: MDL-18215 select all checkbox does not always work.

diff --git a/question/editlib.php b/question/editlib.php
index b45eed6d40f2924af3fef2460cf15e160eed582b..dbe594885ce46a62fba5ec53f7fbedfcb7a1e65c 100644 (file)
--- a/question/editlib.php
+++ b/question/editlib.php
@@ -382,6 +382,7 @@ abstract class question_bank_column_base {
  */
 class question_bank_checkbox_column extends question_bank_column_base {
     protected $strselect;
+    protected $firstrow = true;
 
     public function init() {
         $this->strselect = get_string('select', 'quiz');
@@ -402,8 +403,11 @@ class question_bank_checkbox_column extends question_bank_column_base {
     protected function display_content($question, $rowclasses) {
         echo '<input title="' . $this->strselect . '" type="checkbox" name="q' .
                 $question->id . '" id="checkq' . $question->id . '" value="1"/>';
-        print_js_call('question_bank.init_checkbox_column', array(get_string('selectall'),
-                get_string('deselectall'), 'checkq' . $question->id));
+        if ($this->firstrow) {
+            print_js_call('question_bank.init_checkbox_column', array(get_string('selectall'),
+                    get_string('deselectall'), 'checkq' . $question->id));
+            $this->firstrow = false;
+        }
     }
 
     public function get_required_fields() {