MDL-14663 "link_to_popup_window displays 'Click here....' as the link text if you...

Also fixing the problem in link_to_popup_window function. Test for null instead of empty.

diff --git a/lib/weblib.php b/lib/weblib.php
index 09f9b178ee4b7b894c7552f2b717c44228621308..39f9a34d367ad1d3c64aa2940e78555a602fafc1 100644 (file)
--- a/lib/weblib.php
+++ b/lib/weblib.php
@@ -675,7 +675,7 @@ function element_to_popup_window ($type=null, $url=null, $name=null, $linkname=n
     }
     
     // get some default string, using the localized version of legacy defaults
-    if (!$linkname) {
+    if (is_null($linkname) || $linkname === '') {
         $linkname = get_string('clickhere');
     }
     if (!$title) {