Fix: do not remove allocation if it should be kept

diff --git a/mod/workshop/allocation/random/allocator.php b/mod/workshop/allocation/random/allocator.php
index 7ceca1c9b83dccad8098adcb1b759304a172c120..4591f771b02d3734db4d15280af4ec7df8195551 100644 (file)
--- a/mod/workshop/allocation/random/allocator.php
+++ b/mod/workshop/allocation/random/allocator.php
@@ -119,7 +119,7 @@ class workshop_random_allocator implements workshop_allocator {
                 // random allocator should not be able to delete assessments that have already been graded
                 // by reviewer
                 $o[] = 'info::' . get_string('numofdeallocatedassessment', 'workshop', count($delassessments));
-                foreach ($delassessments as $delassessmentid) {
+                foreach ($delassessments as $delassessmentkey => $delassessmentid) {
                     $a = new stdClass();
                     $a->authorname      = fullname((object)array(
                             'lastname'  => $assessments[$delassessmentid]->authorlastname,
@@ -129,7 +129,7 @@ class workshop_random_allocator implements workshop_allocator {
                             'firstname' => $assessments[$delassessmentid]->reviewerfirstname));
                     if (!is_null($assessments[$delassessmentid]->grade)) {
                         $o[] = 'error::ident::' . get_string('allocationdeallocategraded', 'workshop', $a);
-                        unset($delassessments[$delassessmentid]);
+                        unset($delassessments[$delassessmentkey]);
                     } else {
                         $o[] = 'info::ident::' . get_string('assessmentdeleteddetail', 'workshop', $a);
                     }