MDL-15718 "overview report slow for large data sets - print_user_picture queries...

diff --git a/mod/quiz/report/responses/report.php b/mod/quiz/report/responses/report.php
index aed1073d9ec92507ded082683a39a2a059009896..7237c4fdb55c5944f9d4f77fb3fb80535bf61dd9 100644 (file)
--- a/mod/quiz/report/responses/report.php
+++ b/mod/quiz/report/responses/report.php
@@ -187,7 +187,7 @@ class quiz_responses_report extends quiz_default_report {
             }
             
             $fields .='qa.uniqueid AS attemptuniqueid, qa.id AS attempt, u.id AS userid, u.idnumber, u.firstname,'.
-                ' u.lastname, u.institution, u.department, u.email, u.picture, '.
+                ' u.lastname, u.institution, u.department, u.email, u.picture, u.imagealt, '.
                 'qa.sumgrades, qa.timefinish, qa.timestart, qa.timefinish - qa.timestart AS duration ';
     
             // This part is the same for all cases - join users and quiz_attempts tables

diff --git a/mod/quiz/report/responses/responses_table.php b/mod/quiz/report/responses/responses_table.php
index 4a13c86c485dce877785db051216255dc84e48fb..99a8967870cf00cf8f9ca178040e9b5cd45598b0 100644 (file)
--- a/mod/quiz/report/responses/responses_table.php
+++ b/mod/quiz/report/responses/responses_table.php
@@ -84,7 +84,13 @@ class quiz_report_responses_table extends table_sql {
 
     function col_picture($attempt){
         global $COURSE;
-        return print_user_picture($attempt->userid, $COURSE->id, $attempt->picture, false, true);
+        $user = new object();
+        $user->id = $attempt->userid;
+        $user->lastname = $attempt->lastname;
+        $user->firstname = $attempt->firstname;
+        $user->imagealt = $attempt->imagealt;
+        $user->picture = $attempt->picture;
+        return print_user_picture($user, $COURSE->id, $attempt->picture, false, true);
     }