MDL-15718 "overview report slow for large data sets - print_user_picture queries...

diff --git a/mod/quiz/report/overview/overview_table.php b/mod/quiz/report/overview/overview_table.php
index ce2e69ef439993aaa97be3ba117fa34ed6f28931..dfa4486fefc330f20c810e0e0186af824daea78c 100644 (file)
--- a/mod/quiz/report/overview/overview_table.php
+++ b/mod/quiz/report/overview/overview_table.php
@@ -116,7 +116,13 @@ class quiz_report_overview_table extends table_sql {
 
     function col_picture($attempt){
         global $COURSE;
-        return print_user_picture($attempt->userid, $COURSE->id, $attempt->picture, false, true);
+        $user = new object();
+        $user->id = $attempt->userid;
+        $user->lastname = $attempt->lastname;
+        $user->firstname = $attempt->firstname;
+        $user->imagealt = $attempt->imagealt;
+        $user->picture = $attempt->picture;
+        return print_user_picture($user, $COURSE->id, $attempt->picture, false, true);
     }
 
 

diff --git a/mod/quiz/report/overview/report.php b/mod/quiz/report/overview/report.php
index 59aa06687fd1327249dabb17fd6960901f73c160..c436508de4673ab8ea6871be07f36a9a8b6e3fbe 100644 (file)
--- a/mod/quiz/report/overview/report.php
+++ b/mod/quiz/report/overview/report.php
@@ -249,7 +249,8 @@ class quiz_overview_report extends quiz_default_report {
             // Construct the SQL
             $fields = $DB->sql_concat('u.id', '\'#\'', 'COALESCE(qa.attempt, \'0\')').' AS uniqueid, '.
                 ($qmsubselect?"($qmsubselect) AS gradedattempt, ":'').
-                'qa.uniqueid AS attemptuniqueid, qa.id AS attempt, u.id AS userid, u.idnumber, u.firstname, u.lastname, u.picture, '.
+                'qa.uniqueid AS attemptuniqueid, qa.id AS attempt, ' .
+                'u.id AS userid, u.idnumber, u.firstname, u.lastname, u.picture, u.imagealt, '.
                 'qa.sumgrades, qa.timefinish, qa.timestart, qa.timefinish - qa.timestart AS duration ';
 
             // This part is the same for all cases - join users and quiz_attempts tables