MDL-11466 - failing to check for the case $rs = false in the accesslib performance...

diff --git a/lib/datalib.php b/lib/datalib.php
index 22d15b605334776795e8cd53d4e3f34f86e030c9..cdbfc931a0d268626f078fb462a92ab0a6d9aa4c 100644 (file)
--- a/lib/datalib.php
+++ b/lib/datalib.php
@@ -1240,8 +1240,7 @@ function get_categories($parent='none', $sort=NULL, $shallow=true) {
     }
     $categories = array();
 
-    $rs = get_recordset_sql($sql);
-    if ($rs->RecordCount()) {
+    if( $rs = get_recordset_sql($sql) ){
         while ($cat = rs_fetch_next_record($rs)) {
             $cat = make_context_subobj($cat);
             if ($cat->visible || has_capability('moodle/course:create',$cat->context)) {