MDL-12793 PARAM_HOST incorrect cleaning; merged from MOODLE_19_STABLE

diff --git a/lib/moodlelib.php b/lib/moodlelib.php
index 33f89bf6e792429a838be07f2f945d143a453b34..c0ed3c321b4ec66849af3947524dec1dead11dfe 100644 (file)
--- a/lib/moodlelib.php
+++ b/lib/moodlelib.php
@@ -452,7 +452,7 @@ function clean_param($param, $type) {
             return ereg_replace('/(\./)+', '/', $param);
 
         case PARAM_HOST:         // allow FQDN or IPv4 dotted quad
-            preg_replace('/[^\.\d\w-]/','', $param ); // only allowed chars
+            $param = preg_replace('/[^\.\d\w-]/','', $param ); // only allowed chars
             // match ipv4 dotted quad
             if (preg_match('/(\d{1,3})\.(\d{1,3})\.(\d{1,3})\.(\d{1,3})/',$param, $match)){
                 // confirm values are ok