portfolio MDL-20894 better checking of no common formats

diff --git a/lib/portfoliolib.php b/lib/portfoliolib.php
index 50b1b80a01bc7b1b5b5a7bf211b1e8158e2530f1..994edbf533a86bd49786d16de05076dd865e6964 100644 (file)
--- a/lib/portfoliolib.php
+++ b/lib/portfoliolib.php
@@ -242,7 +242,9 @@ class portfolio_add_button {
             $linkoutput .= '&instance=' . $instance->get('id');
         }
         else {
-            $selectoutput = portfolio_instance_select($this->instances, $this->formats, $this->callbackclass, 'instance', true);
+            if (!$selectoutput = portfolio_instance_select($this->instances, $this->formats, $this->callbackclass, 'instance', true)) {
+                return;
+            }
         }
 
         if (empty($addstr)) {