Added conditional rename/add for field external

diff --git a/mod/scorm/db/upgrade.php b/mod/scorm/db/upgrade.php
index 3d428c57d579a9f3236eee99a75cb97ccf8aeaea..30ba1e3ebf1a5ff4bb4ae396cd9f5da06efeb0df 100644 (file)
--- a/mod/scorm/db/upgrade.php
+++ b/mod/scorm/db/upgrade.php
@@ -223,10 +223,17 @@ function xmldb_scorm_upgrade($oldversion=0) {
         $table = new XMLDBTable('scorm');
         $field = new XMLDBField('external');
 
-        $field->setAttributes(XMLDB_TYPE_INTEGER, '1', XMLDB_UNSIGNED, XMLDB_NOTNULL, null, null, null, '0', 'maxattempt');
+        if (field_exists($table, $field)) {
+            $field->setAttributes(XMLDB_TYPE_INTEGER, '1', XMLDB_UNSIGNED, XMLDB_NOTNULL, null, null, null, '0', 'maxattempt');
+
+         /// Launch rename field updatefreq
+            $result = $result && rename_field($table, $field, 'updatefreq');
+        } else {
+            $field = new XMLDBField('updatefreq');
+            $field->setAttributes(XMLDB_TYPE_INTEGER, '1', XMLDB_UNSIGNED, XMLDB_NOTNULL, null, null, null, '0', 'maxattempt');
 
-    /// Launch rename field updatefreq
-        $result = $result && rename_field($table, $field, 'updatefreq');
+            $result = $result && add_field($table, $field);
+        }
 
     /// Rename field md5_result on table scorm to md5hash
         $field = new XMLDBField('md5_result');