Fixed Bug #5057 - hidden teachers aren't completely hidden

diff --git a/blocks/online_users/block_online_users.php b/blocks/online_users/block_online_users.php
index b7f38bd0bd936441242d671c519d49d6ad43882a..a6ccfa36e0f39b160ff478b14985021a90a4edfc 100644 (file)
--- a/blocks/online_users/block_online_users.php
+++ b/blocks/online_users/block_online_users.php
@@ -82,14 +82,21 @@ class block_online_users extends block_base {
             }
         }
 
-        if ($teachers = get_records_sql("SELECT u.id, u.username, u.firstname, u.lastname, u.picture, u.lastaccess, s.timeaccess
+        $findteacherssql = "SELECT u.id, u.username, u.firstname, u.lastname, u.picture, u.lastaccess, s.timeaccess
                                      FROM {$CFG->prefix}user u,
                                           {$CFG->prefix}user_teachers s
                                           $groupmembers
-                                     WHERE u.id = s.userid $courseselect $groupselect $timeselect
-                                  ORDER BY s.timeaccess DESC")) {
+                                     WHERE u.id = s.userid $courseselect $groupselect $timeselect ";
+
+        if (!isteacher($course->id)) {
+            // Hide hidden teachers from students.
+            $findteacherssql .= 'AND s.authority > 0 ';
+        }
+        $findteacherssql .= 'ORDER BY s.timeaccess DESC';
+
+        if ($teachers = get_records_sql($findteacherssql)) {
             foreach ($teachers as $teacher) {
-                $teacher->fullname = '<b>'.fullname($teacher).'</b>';
+                $teacher->fullname = '<strong>'.fullname($teacher).'</strong>';
                 $users[$teacher->id] = $teacher;
             }
         }