fixed bug in online user list, see http://moodle.org/mod/forum/discuss.php?d=11554

diff --git a/blocks/online_users/block_online_users.php b/blocks/online_users/block_online_users.php
index da7cf35cdd72ac28bafcfed508f8c2dc1bbfa119..eb21824ae71b3b6d9ae192846ab6d92a9b63be96 100644 (file)
--- a/blocks/online_users/block_online_users.php
+++ b/blocks/online_users/block_online_users.php
@@ -63,28 +63,28 @@ class CourseBlock_online_users extends MoodleBlock {
             $groupselect .= " AND u.id = gm.userid AND gm.groupid = '$currentgroup'";
         }
 
+        $timefrom = time()-$timetoshowusers;
+
         if (empty($this->course->category)) {  // Site-level
             $courseselect = '';
+            $timeselect = "AND u.lastaccess > $timefrom";
         } else {
             $courseselect = "AND s.course = '".$this->course->id."'";
+            $timeselect = "AND s.timeaccess > $timefrom";
         }
 
-        $timefrom = time()-$timetoshowusers;
-
         $students = get_records_sql("SELECT u.id, u.username, u.firstname, u.lastname, u.picture, s.timeaccess
                                      FROM {$CFG->prefix}user u,
                                           {$CFG->prefix}user_students s
                                           $groupmembers
-                                     WHERE u.id = s.userid $courseselect $groupselect
-                                       AND s.timeaccess > $timefrom 
+                                     WHERE u.id = s.userid $courseselect $groupselect $timeselect 
                                   ORDER BY s.timeaccess DESC");
 
         $teachers = get_records_sql("SELECT u.id, u.username, u.firstname, u.lastname, u.picture, s.timeaccess
                                      FROM {$CFG->prefix}user u,
                                           {$CFG->prefix}user_teachers s
                                           $groupmembers
-                                     WHERE u.id = s.userid $courseselect $groupselect
-                                       AND s.timeaccess > $timefrom 
+                                     WHERE u.id = s.userid $courseselect $groupselect $timeselect
                                   ORDER BY s.timeaccess DESC");
 
         if ($teachers || $students) {