Silly conditions produce silly results, please. :-P

(WHERE 1 is not cross-db at all)

diff --git a/lib/db/upgrade.php b/lib/db/upgrade.php
index b5ae9f1e96ed7bd3084cec1714f19133fd5ec075..4688173e3b4775b6c715f0fb8831444efc9be079 100644 (file)
--- a/lib/db/upgrade.php
+++ b/lib/db/upgrade.php
@@ -479,7 +479,7 @@ function xmldb_main_upgrade($oldversion=0) {
         $result = $result && change_field_type($table, $field);
 
         /// For existing fields use 'name' as the 'shortname' entry
-        if ($fields = get_records_select('user_info_field', 1, '', 'id, name')) {
+        if ($fields = get_records_select('user_info_field', '', '', 'id, name')) {
             foreach ($fields as $field) {
                 $field->shortname = clean_param($field->name, PARAM_ALPHANUM);
                 $result && update_record('user_info_field', $field);