Bug #5732 - Lesson Scores "out of XX" marks report incorrect mark; merged...

diff --git a/mod/lesson/locallib.php b/mod/lesson/locallib.php
index d6798da6acc548b6589cce38cb8310da1daf0cae..f4dbf8fb6b202d7fbbbb59c5fa7136069027a61f 100644 (file)
--- a/mod/lesson/locallib.php
+++ b/mod/lesson/locallib.php
@@ -1286,9 +1286,9 @@ function lesson_grade($lesson, $ntries, $userid = 0) {
             $bestscores = array();
             // Find the highest possible score per page to get our total
             foreach ($answers as $answer) {
-                if(isset($bestscores[$answer->pageid]) and $bestscores[$answer->pageid] < $answer->score) {
+                if(!isset($bestscores[$answer->pageid])) {
                     $bestscores[$answer->pageid] = $answer->score;
-                } else {
+                } else if ($bestscores[$answer->pageid] < $answer->score) {
                     $bestscores[$answer->pageid] = $answer->score;
                 }
             }