MDL-21142 minor cleanup in out() default params

diff --git a/admin/settings.php b/admin/settings.php
index 10b9f6b727a6e4c17b1d04f927043940dd05d5c6..04bf9bc64e1d7098e8f5a2369fba06bda2da7e56 100644 (file)
--- a/admin/settings.php
+++ b/admin/settings.php
@@ -97,7 +97,7 @@ if (empty($SITE->fullname)) {
             $caption = get_string('blocksediton');
             $options['adminedit'] = 'on';
         }
-        $buttons = $OUTPUT->button(html_form::make_button($PAGE->url->out(false), $options, $caption, 'get'));
+        $buttons = $OUTPUT->button(html_form::make_button($PAGE->url->out(), $options, $caption, 'get'));
     }
 
     $visiblepathtosection = array_reverse($settingspage->visiblepath);

diff --git a/lib/adminlib.php b/lib/adminlib.php
index 08cad4d3aa950e6184695cf5936059001b6a327f..11dbdb97e22b80e7395bb66253a82ee0d038a898 100644 (file)
--- a/lib/adminlib.php
+++ b/lib/adminlib.php
@@ -5263,7 +5263,7 @@ function admin_externalpage_print_header($focus='') {
             $caption = get_string('blocksediton');
             $options['adminedit'] = 'on';
         }
-        $buttons = $OUTPUT->button(html_form::make_button($PAGE->url->out(false), $options, $caption, 'get'));
+        $buttons = $OUTPUT->button(html_form::make_button($PAGE->url->out(), $options, $caption, 'get'));
     }
 
     $PAGE->set_title("$SITE->shortname: " . implode(": ",$visiblepathtosection));

diff --git a/lib/pagelib.php b/lib/pagelib.php
index 3b34c2aaeaa52a3065a41444640f3129102e34d3..1f3879f5cb82b3a7887e0808728282a48151fb52 100644 (file)
--- a/lib/pagelib.php
+++ b/lib/pagelib.php
@@ -1378,8 +1378,8 @@ class moodle_page {
      * @return string URL for this page without parameters.
      */
     function url_get_path() {
-        debugging('Call to deprecated method moodle_page::url_get_path. Use $this->url->out(false) instead.');
-        return $this->url->out(false);
+        debugging('Call to deprecated method moodle_page::url_get_path. Use $this->url->out() instead.');
+        return $this->url->out();
     }
 
     /**

diff --git a/mod/quiz/editlib.php b/mod/quiz/editlib.php
index 0caf62fc52e41bae161a1595bc6c2dc40c839e15..96e1ac71f629690afebbe8e070f90b03c07004e4 100644 (file)
--- a/mod/quiz/editlib.php
+++ b/mod/quiz/editlib.php
@@ -654,7 +654,7 @@ function quiz_print_pagecontrols($quiz, $pageurl, $page, $hasattempts) {
     $returnurl_addtoquiz = new moodle_url($pageurl->out(true), array('addonpage' => $page));
 
     // Print a button linking to the choose question type page.
-    $newquestionparams = array('returnurl' => $returnurl_addtoquiz->out(false),
+    $newquestionparams = array('returnurl' => $returnurl_addtoquiz->out(),
             'cmid' => $quiz->cmid, 'appendqnumstring' => 'addquestion');
     create_new_question_button($defaultcategory->id, $newquestionparams, get_string('addaquestion', 'quiz'),
             get_string('createquestionandadd', 'quiz'), $hasattempts);

diff --git a/question/editlib.php b/question/editlib.php
index df9a6c6cc6242b48e7d746cae60587c52eaa1025..0f5a4a1b157631a185e514083f87fa7693b0191c 100644 (file)
--- a/question/editlib.php
+++ b/question/editlib.php
@@ -1535,7 +1535,7 @@ function question_edit_setup($edittab, $requirecmid = false, $requirecourseid =
     //$thispageurl is used to construct urls for all question edit pages we link to from this page. It contains an array
     //of parameters that are passed from page to page.
     $thispageurl = new moodle_url();
-    $thispageurl->remove_params(); // We are going to explicity add back everything important - this avoids unwanted params from being retained.
+    $thispageurl->remove_all_params(); // We are going to explicity add back everything important - this avoids unwanted params from being retained.
 
     if ($requirecmid){
         $cmid =required_param('cmid', PARAM_INT);

diff --git a/repository/filepicker.php b/repository/filepicker.php
index f7e703441e9de540ae9a5569d91734979ee2bdd0..08ecfdba2e2fb714ea3bc4f7417c3c1272ca3b6b 100755 (executable)
--- a/repository/filepicker.php
+++ b/repository/filepicker.php
@@ -170,7 +170,7 @@ case 'sign':
         $list = $repo->get_listing($req_path, $curr_page);
         $dynload = !empty($list['dynload'])?true:false;
         if (!empty($list['upload'])) {
-            echo '<form action="'.$url->out(false).'" method="post" enctype="multipart/form-data" style="display:inline">';
+            echo '<form action="'.$url->out().'" method="post" enctype="multipart/form-data" style="display:inline">';
             echo '<label>'.$list['upload']['label'].': </label>';
             echo '<input type="file" name="repo_upload_file" /><br />';
             echo '<input type="hidden" name="action" value="upload" /><br />';