FIxed up logging when viewing submissions (database truncation in logs)

Thanks Eloy!

diff --git a/mod/assignment/db/mysql.php b/mod/assignment/db/mysql.php
index 62267350f2e9a5463ec99310a7d2378cee4b16f6..f05f00edf5cad8c5920a69e69b53287cf4de348f 100644 (file)
--- a/mod/assignment/db/mysql.php
+++ b/mod/assignment/db/mysql.php
@@ -91,6 +91,9 @@ function assignment_upgrade($oldversion) {
     if ($oldversion < 2002122300) {
         execute_sql("ALTER TABLE `assignment_submissions` CHANGE `user` `userid` INT(10) UNSIGNED DEFAULT '0' NOT NULL ");
     }
+    if ($oldversion < 2004021700) {
+        set_field("log_display", "action", "view submission", "module", "assignment", "action", "view submissions");
+    }
 
     return true;
 }

diff --git a/mod/assignment/db/mysql.sql b/mod/assignment/db/mysql.sql
index c4f431cf613d8c248249dca095d8d399a5812758..a8d75e08f132fe1152e7414791b673317cf8e45e 100644 (file)
--- a/mod/assignment/db/mysql.sql
+++ b/mod/assignment/db/mysql.sql
@@ -42,6 +42,6 @@ CREATE TABLE `prefix_assignment_submissions` (
 INSERT INTO prefix_log_display VALUES ('assignment', 'view', 'assignment', 'name');
 INSERT INTO prefix_log_display VALUES ('assignment', 'add', 'assignment', 'name');
 INSERT INTO prefix_log_display VALUES ('assignment', 'update', 'assignment', 'name');
-INSERT INTO prefix_log_display VALUES ('assignment', 'view submissions', 'assignment', 'name');
+INSERT INTO prefix_log_display VALUES ('assignment', 'view submission', 'assignment', 'name');
 INSERT INTO prefix_log_display VALUES ('assignment', 'upload', 'assignment', 'name');
 

diff --git a/mod/assignment/db/postgres7.php b/mod/assignment/db/postgres7.php
index b8b25556cc0815cd885348da2936a9664434f692..9f945e0dc41b5262aa4cccb3ba341245a952d616 100644 (file)
--- a/mod/assignment/db/postgres7.php
+++ b/mod/assignment/db/postgres7.php
@@ -88,6 +88,9 @@ function assignment_upgrade($oldversion) {
         table_column("assignment", "", "resubmit", "integer", "2", "unsigned", "0", "", "format");
     }
 
+    if ($oldversion < 2004021700) {
+        set_field("log_display", "action", "view submission", "module", "assignment", "action", "view submissions");
+    }
 
     return true;
 }

diff --git a/mod/assignment/db/postgres7.sql b/mod/assignment/db/postgres7.sql
index a9589d27f22d5652022c5c6bf99e54cfc5e763ef..3738bbccb745cd5c61c09030355eeb154e78295a 100644 (file)
--- a/mod/assignment/db/postgres7.sql
+++ b/mod/assignment/db/postgres7.sql
@@ -40,6 +40,6 @@ CREATE TABLE prefix_assignment_submissions (
 INSERT INTO prefix_log_display VALUES ('assignment', 'view', 'assignment', 'name');
 INSERT INTO prefix_log_display VALUES ('assignment', 'add', 'assignment', 'name');
 INSERT INTO prefix_log_display VALUES ('assignment', 'update', 'assignment', 'name');
-INSERT INTO prefix_log_display VALUES ('assignment', 'view submissions', 'assignment', 'name');
+INSERT INTO prefix_log_display VALUES ('assignment', 'view submission', 'assignment', 'name');
 INSERT INTO prefix_log_display VALUES ('assignment', 'upload', 'assignment', 'name');
 

diff --git a/mod/assignment/submissions.php b/mod/assignment/submissions.php
index 02a5151543ab8fa0346d10d4203246639aa772f7..4974ad4d815afd424339195ff11a302af10e5094 100644 (file)
--- a/mod/assignment/submissions.php
+++ b/mod/assignment/submissions.php
@@ -136,7 +136,7 @@
         add_to_log($course->id, "assignment", "update grades", "submissions.php?id=$assignment->id", "$count users", $cm->id);
         notify(get_string("feedbackupdated", "assignment", $count));
     } else {
-        add_to_log($course->id, "assignment", "view submissions", "submissions.php?id=$assignment->id", "$assignment->id", $cm->id);
+        add_to_log($course->id, "assignment", "view submission", "submissions.php?id=$assignment->id", "$assignment->id", $cm->id);
     }
 
     // Submission sorting

diff --git a/mod/assignment/version.php b/mod/assignment/version.php
index b36114e59756c3286f794b4980708524fbe705ed..366ca5c2da106020297728ce9145fb072dac170f 100644 (file)
--- a/mod/assignment/version.php
+++ b/mod/assignment/version.php
@@ -5,7 +5,7 @@
 //  This fragment is called by /admin/index.php
 ////////////////////////////////////////////////////////////////////////////////
 
-$module->version  = 2004020500;
+$module->version  = 2004021700;
 $module->requires = 2004013101;  // Requires this Moodle version
 $module->cron     = 60;