Removed redundant up/down arrows ... let's see how everyone feels about it

diff --git a/course/lib.php b/course/lib.php
index 4a99cec357e4fc0417fe5ed4b6ecea1357ae2ac9..f8c02c938b28ae1503ccbdbd6bbffe42c4ec7690 100644 (file)
--- a/course/lib.php
+++ b/course/lib.php
@@ -1252,12 +1252,12 @@ function make_editing_buttons($moduleid, $absolute=false, $visible=true, $movese
     static $str = '';
     if (empty($str)) {
         $str->delete   = get_string("delete");
+        $str->move     = get_string("move");
         $str->moveup   = get_string("moveup");
         $str->movedown = get_string("movedown");
         $str->update   = get_string("update");
         $str->hide     = get_string("hide");
         $str->show     = get_string("show");
-        $str->move     = get_string("move");
     }
 
     if ($absolute) {
@@ -1283,14 +1283,15 @@ function make_editing_buttons($moduleid, $absolute=false, $visible=true, $movese
     if ($moveselect) {
         $move =     "<a title=\"$str->move\" href=\"$path/mod.php?copy=$moduleid\"><img".
                     " src=\"$pixpath/t/move.gif\" height=\"11\" width=\"11\" border=\"0\"></a> ";
+    } else {
+        $move =     "<a title=\"$str->moveup\" href=\"$path/mod.php?id=$moduleid&move=-1\"><img".
+                    " src=\"$pixpath/t/up.gif\" height=11 width=11 border=0></a> ".
+                    "<a title=\"$str->movedown\" href=\"$path/mod.php?id=$moduleid&move=1\"><img".
+                    " src=\"$pixpath/t/down.gif\" height=11 width=11 border=0></a> ";
     }
 
     return "<a title=\"$str->delete\" href=\"$path/mod.php?delete=$moduleid\"><img".
-           " src=\"$pixpath/t/delete.gif\" height=11 width=11 border=0></a> ".
-           "<a title=\"$str->moveup\" href=\"$path/mod.php?id=$moduleid&move=-1\"><img".
-           " src=\"$pixpath/t/up.gif\" height=11 width=11 border=0></a> ".
-           "<a title=\"$str->movedown\" href=\"$path/mod.php?id=$moduleid&move=1\"><img".
-           " src=\"$pixpath/t/down.gif\" height=11 width=11 border=0></a> $move".
+           " src=\"$pixpath/t/delete.gif\" height=11 width=11 border=0></a> $move".
            "<a title=\"$str->update\" href=\"$path/mod.php?update=$moduleid\"><img".
            " src=\"$pixpath/t/edit.gif\" height=11 width=11 border=0></a> $hideshow";
 }