MDL-10873 Now deleting the preference from user_preferences if the value submitted...

diff --git a/grade/report/grader/preferences.php b/grade/report/grader/preferences.php
index 0ee4e413300c1c496df8fb6511b455c06d656dd5..b190c7dd2c3906496af85ddf002513cba003ad7f 100644 (file)
--- a/grade/report/grader/preferences.php
+++ b/grade/report/grader/preferences.php
@@ -41,14 +41,15 @@ $context = get_context_instance(CONTEXT_COURSE, $course->id);
 require_capability('gradereport/grader:manage', $context);
 
 // If data submitted, then process and store.
-if ($form = data_submitted()) {
-    foreach ($form as $preference => $value) {
+if ($data = data_submitted()) {
+
+    foreach ($data as $preference => $value) {
         switch ($preference) {
             case 'persistflt':
                 set_user_preference('calendar_persistflt', intval($value));
                 break;
             default:
-                if ($value == GRADE_REPORT_PREFERENCE_DEFAULT) {
+                if ($value == GRADE_REPORT_PREFERENCE_DEFAULT || empty($value)) {
                     unset_user_preference($preference);
                 } else {
                     set_user_preference($preference, $value);
@@ -77,7 +78,7 @@ print_grade_plugin_selector($course->id, 'report', 'grader');
 if (has_capability('moodle/site:config')) {
     echo '<div id="siteconfiglink"><a href="' . $CFG->wwwroot . '/admin/settings.php?section=gradereportgrader">';
     echo get_string('changesitedefaults', 'grades');
-    echo "</div>\n";
+    echo "</a></div>\n";
 }
 
 // Add tabs