adding proper checks that the requested help file exists SC#292; merged from MOODLE_1...

diff --git a/help.php b/help.php
index e24b6160877821fd367e5bccefd6e8b929eab5ff..ef420dfd2700bf9347fb7a1dcece21eea4892e26 100644 (file)
--- a/help.php
+++ b/help.php
@@ -56,9 +56,9 @@
                 }
             }
 
-            if (file_exists($filepath)) {
+            if (file_exists($filepath) and is_file($filepath) and is_readable($filepath)) {
                 $helpfound = true;
-                include($filepath);   // The actual helpfile
+                @include($filepath);   // The actual helpfile
 
                 if ($module == 'moodle' and ($file == 'index.html' or $file == 'mods.html')) {
                     // include file for each module