Robustness fixes

diff --git a/mod/quiz/lib.php b/mod/quiz/lib.php
index 5a68d45a03ca299d64190cd34e9dac4bc4988995..f2ea641bb8d9c6df6cb4e72c375c4ee241a1b27a 100644 (file)
--- a/mod/quiz/lib.php
+++ b/mod/quiz/lib.php
@@ -969,7 +969,7 @@ function quiz_save_attempt($quiz, $questions, $result, $attemptnum) {
         $response->attempt = $attempt->id;
         $response->question = $question->id;
         $response->grade = $result->grades[$question->id];
-        if ($question->answer) {
+        if (!empty($question->answer)) {
             $response->answer = implode(",",$question->answer);
         } else {
             $response->answer = "";
@@ -1064,7 +1064,7 @@ function quiz_grade_attempt_results($quiz, $questions) {
                     if ($answer->fraction > 0) {
                         $correct[$answer->id] = true;
                     }
-                    if ($question->answer) {
+                    if (!empty($question->answer)) {
                         foreach ($question->answer as $questionanswer) {
                             if ($questionanswer == $answer->id) {
                                 if ($answer->single) {

diff --git a/mod/quiz/mod.html b/mod/quiz/mod.html
index 139311f5c2f0fa0af3dc24f4654968f54aa22edf..ed70d9b5a9ac08e67adbe022eb586878ccb76525 100644 (file)
--- a/mod/quiz/mod.html
+++ b/mod/quiz/mod.html
@@ -17,7 +17,7 @@
         $form->timeclose = "";
     }
     if (empty($form->attempts)) {
-        $form->attempts = "";
+        $form->attempts = "0";
     }
     if (empty($form->grademethod)) {
         $form->grademethod = "";

diff --git a/mod/quiz/multichoice.html b/mod/quiz/multichoice.html
index 9a1bc4b4557c5d1d3518e19eb2081b3e94cb91c6..0b95a1409b0fe69264665359eee01360cc095df4 100644 (file)
--- a/mod/quiz/multichoice.html
+++ b/mod/quiz/multichoice.html
@@ -29,7 +29,7 @@
 <TR valign=top>\r
     <TD align=right><P><B><? print_string("imagedisplay", "quiz") ?>:</B></P></TD>\r
     <TD>\r
-    <?  if (!$images) {\r
+    <?  if (empty($images)) {\r
             print_string("noimagesyet");\r
         } else {\r
             choose_from_menu($images, "image", "$question->image", get_string("none"),"","");\r

diff --git a/mod/quiz/question.php b/mod/quiz/question.php
index 75ddc40fc7e1505d978db7c5b63736e63acac5f5..1732c2ddba0b5ebb41a43a64f40cc0b31f50c949 100644 (file)
--- a/mod/quiz/question.php
+++ b/mod/quiz/question.php
@@ -99,7 +99,11 @@
         // First, save the basic question itself
         $question->name         = $form->name;
         $question->questiontext = $form->questiontext;
-        $question->image        = $form->image;
+        if (empty($form->image)) {
+            $question->image = "";
+        } else {
+            $question->image = $form->image;
+        }
         $question->category     = $form->category;
 
         if (!$err = formcheck($question)) {
@@ -127,7 +131,7 @@
     
                     // Insert all the new answers
                     foreach ($form->answer as $key => $formanswer) {
-                        if ($formanswer) {
+                        if ($formanswer != "") {
                             unset($answer);
                             $answer->answer   = $formanswer;
                             $answer->question = $question->id;
@@ -198,7 +202,7 @@
     
                     // Insert all the new answers
                     foreach ($form->answer as $key => $formanswer) {
-                        if ($formanswer) {
+                        if ($formanswer != "") {
                             unset($answer);
                             $answer->answer   = $formanswer;
                             $answer->question = $question->id;

diff --git a/mod/quiz/shortanswer.html b/mod/quiz/shortanswer.html
index 063b883cfebc55eb580da4904f1334bc8536f00e..03fcd781600763f1aecf41efb446fffbe665dcff 100644 (file)
--- a/mod/quiz/shortanswer.html
+++ b/mod/quiz/shortanswer.html
@@ -29,7 +29,7 @@
 <TR valign=top>\r
     <TD align=right><P><B><? print_string("imagedisplay", "quiz") ?>:</B></P></TD>\r
     <TD>\r
-    <?  if (!$images) {\r
+    <?  if (empty($images)) {\r
             print_string("noimagesyet");\r
         } else {\r
             choose_from_menu($images, "image", "$question->image", get_string("none"),"","");\r

diff --git a/mod/quiz/truefalse.html b/mod/quiz/truefalse.html
index bc43738288e499fc3ec6a54db87d966f795e8f9b..cf87b47feb5c2b1fa2eb20303e891798b38fd110 100644 (file)
--- a/mod/quiz/truefalse.html
+++ b/mod/quiz/truefalse.html
@@ -29,7 +29,7 @@
 <TR valign=top>\r
     <TD align=right><P><B><? print_string("imagedisplay", "quiz") ?>:</B></P></TD>\r
     <TD>\r
-    <?  if (!$images) {\r
+    <?  if (empty($images)) {\r
             print_string("noimagesyet");\r
         } else {\r
             choose_from_menu($images, "image", "$question->image", get_string("none"),"","");\r