MDL-12400 - superfluous required_param causing problems in upload

assignment user report.

diff --git a/mod/assignment/type/upload/assignment.class.php b/mod/assignment/type/upload/assignment.class.php
index 15054d7dce22b40ad12c63d841b49c075131bd2f..710862866ee46abb9d13db05db1f5c71cf078c32 100644 (file)
--- a/mod/assignment/type/upload/assignment.class.php
+++ b/mod/assignment/type/upload/assignment.class.php
@@ -324,9 +324,8 @@ class assignment_upload extends assignment_base {
             }
 
             if ($this->notes_allowed() and !empty($submission->data1) and !empty($mode)) { // only during grading
-                $offset = required_param('offset', PARAM_INT);
 
-                $npurl = "type/upload/notes.php?id={$this->cm->id}&userid=$userid&offset=$offset&mode=single";
+                $npurl = $CFG->wwwroot."/mod/assignment/type/upload/notes.php?id={$this->cm->id}&userid=$userid&offset=$offset&mode=single";
                 $output .= '<a href="'.$npurl.'">'.get_string('notes', 'assignment').'</a><br />';
 
             }