MDL-17524 Deleting a calculated question delete datasetdefinitions shared by other...

diff --git a/question/type/calculated/questiontype.php b/question/type/calculated/questiontype.php
index 72333f7a3e7db41eee67d312d0e7b8cdffea4f20..685b9492c2ee6cc5c99b471fc7c92f8bd4355d0a 100644 (file)
--- a/question/type/calculated/questiontype.php
+++ b/question/type/calculated/questiontype.php
@@ -632,6 +632,10 @@ class question_calculated_qtype extends default_questiontype {
         $DB->delete_records("question_numerical_units", array("question" => $questionid));
         if ($datasets = $DB->get_records('question_datasets', array('question' => $questionid))) {
             foreach ($datasets as $dataset) {
+                if (!$DB->get_records_select(
+                        'question_datasets',
+                        "question != ?
+                        AND datasetdefinition = ?;", array($questionid, $dataset->datasetdefinition))){                                 
                 $DB->delete_records('question_dataset_definitions', array('id' => $dataset->datasetdefinition));
                 $DB->delete_records('question_dataset_items', array('definition' => $dataset->datasetdefinition));
             }