Some improved popup windows / links for user pictures

diff --git a/mod/chat/lib.php b/mod/chat/lib.php
index 4f9d040ccefee9728674cc2bb9e2053f35f909f8..ec7397a9afd69ac4fab91d88bcac332dd1f57810 100644 (file)
--- a/mod/chat/lib.php
+++ b/mod/chat/lib.php
@@ -407,7 +407,7 @@ function chat_display_version($version, $browser)
 }
 
 
-function chat_format_message($message) {
+function chat_format_message($message, $courseid=0) {
 /// Given a message object full of information, this function 
 /// formats it appropriately into text and html, then 
 /// returns the formatted data.
@@ -421,6 +421,9 @@ function chat_format_message($message) {
     }
 
     $picture = print_user_picture($user->id, 0, $user->picture, false, true, false);
+    if ($courseid) {
+        $picture = "<a target=\"_new\" href=\"$CFG->wwwroot/user/view.php?id=$user->id&course=$courseid\">$picture</a>";
+    }
 
     $strtime = userdate($message->timestamp, get_string("strftimemessage", "chat"));
 

diff --git a/mod/chat/report.php b/mod/chat/report.php
index 11fce4e38eb24441fe605a0f2a90faef9533c550..3a64c0629ba5e4e2e7ecfef699d562d25175db9d 100644 (file)
--- a/mod/chat/report.php
+++ b/mod/chat/report.php
@@ -30,7 +30,7 @@
 /// Print the page header
 
     if ($course->category) {
-        $navigation = "<A HREF=\"../../course/view.php?id=$course->id\">$course->shortname</A> ->";
+        $navigation = "<a href=\"../../course/view.php?id=$course->id\">$course->shortname</a> ->";
     }
 
     $strchats = get_string("modulenameplural", "chat");
@@ -58,7 +58,7 @@
 
             print_simple_box_start("center");
             foreach ($messages as $message) {  // We are walking FORWARDS through messages
-                $formatmessage = chat_format_message($message);
+                $formatmessage = chat_format_message($message, $course->id);
                 echo $formatmessage->html;
             }
             print_simple_box_end("center");

diff --git a/mod/chat/users.php b/mod/chat/users.php
index 2034611e99cce9b702dfaf59bcd683cf8ac07d75..fb95c0ed5a06a3cd910bd9538bc105960428d903 100644 (file)
--- a/mod/chat/users.php
+++ b/mod/chat/users.php
@@ -90,8 +90,9 @@ echo "<table width=\"100%\">";
 foreach ($chatusers as $chatuser) {
     $lastping = $timenow - $chatuser->lastmessageping;
     echo "<tr><td width=35>";
+    echo "<a target=\"_new\" onClick=\"return openpopup('/user/view.php?id=$chatuser->id&course=$chat->course','user$chatuser->id','');\" href=\"$CFG->wwwroot/user/view.php?id=$chatuser->id&course=$chat->course\">";
     print_user_picture($chatuser->id, 0, $chatuser->picture, false, false, false);
-    echo "</td><td valign=center>";
+    echo "</a></td><td valign=center>";
     echo "<p><font size=1>";
     echo "$chatuser->firstname $chatuser->lastname<br />";
     echo "<font color=\"#888888\">$stridle: ".format_time($lastping, $str)."</font>";

diff --git a/mod/chat/view.php b/mod/chat/view.php
index 962b941243574df88dd314c95d105f64a482a156..2e7c006952f421a512ebe06ab69e656a72896e11 100644 (file)
--- a/mod/chat/view.php
+++ b/mod/chat/view.php
@@ -98,8 +98,9 @@
         foreach ($chatusers as $chatuser) {
             $lastping = $timenow - $chatuser->lastmessageping;
             echo "<tr><td width=35>";
+            echo "<a href=\"$CFG->wwwroot/user/view.php?id=$chatuser->id&course=$chat->course\">";
             print_user_picture($chatuser->id, 0, $chatuser->picture, false, false, false);
-            echo "</td><td valign=center>";
+            echo "</a></td><td valign=center>";
             echo "<p><font size=1>";
             echo "$chatuser->firstname $chatuser->lastname<br />";
             echo "<font color=\"#888888\">$stridle: ".format_time($lastping, $str)."</font>";