navigation MDL-20242 Fixed bug whereby sections that no longer exist were shown

diff --git a/lib/navigationlib.php b/lib/navigationlib.php
index 24ed7c7ec760565f611e83eb01ef959b1eaa95cd..9f39423c3ecfffaae1aa2d0dcccb1aeafd0f9118 100644 (file)
--- a/lib/navigationlib.php
+++ b/lib/navigationlib.php
@@ -1318,6 +1318,13 @@ class global_navigation extends navigation_node {
         $viewhiddensections = $this->cache->canviewhiddensections;
 
         $selectedstructure = optional_param($activeparam,false,PARAM_INT);
+
+        // This is required to make sure that if people have reduced the number
+        // of sections after adding activities to sections that no longer exist
+        // we dont show them
+        // MDL-20242
+        $sections = array_slice($sections, 0, $course->numsections, true);
+
         foreach ($sections as $section) {
             if ((!$viewhiddensections && !$section->visible) || (!$this->showemptybranches && !array_key_exists($section->section, $modinfo->sections))) {
                 continue;