page parameter cleanup

diff --git a/mod/assignment/submissions.php b/mod/assignment/submissions.php
index 5e3c40abd4da625b5c4c885b79b1836ccd4e71d8..6b5693d98bdd7ac790f9349b92234473f5ed559a 100644 (file)
--- a/mod/assignment/submissions.php
+++ b/mod/assignment/submissions.php
@@ -3,9 +3,9 @@
     require_once("../../config.php");
     require_once("lib.php");
 
-    $id      = optional_param('id');            // Course module ID
-    $a       = optional_param('a');             // Assignment ID
-    $mode    = optional_param('mode', 'all');   // What mode are we in?
+    $id   = optional_param('id', 0, PARAM_INT);          // Course module ID
+    $a    = optional_param('a', 0, PARAM_INT);           // Assignment ID
+    $mode = optional_param('mode', 'all', PARAM_ALPHA);  // What mode are we in?
 
     if ($id) {
         if (! $cm = get_record("course_modules", "id", $id)) {

diff --git a/mod/assignment/upload.php b/mod/assignment/upload.php
index 231048d5dc6796d2ce518481a591b7032162612a..cfb862753b13ed96a574c64bf2bd2b865a289b2e 100644 (file)
--- a/mod/assignment/upload.php
+++ b/mod/assignment/upload.php
@@ -3,8 +3,8 @@
     require_once("../../config.php");
     require_once("lib.php");
 
-    $id      = optional_param('id');            // Course module ID
-    $a       = optional_param('a');             // Assignment ID
+    $id = optional_param('id', 0, PARAM_INT);  // Course module ID
+    $a  = optional_param('a', 0, PARAM_INT);   // Assignment ID
 
     if ($id) {
         if (! $cm = get_record("course_modules", "id", $id)) {

diff --git a/mod/assignment/view.php b/mod/assignment/view.php
index 437922c0a32bf052ca6905b87144f7cd2e0e4ec8..a773b77353309c50650c91818f66023e6ff30fb4 100644 (file)
--- a/mod/assignment/view.php
+++ b/mod/assignment/view.php
@@ -3,9 +3,8 @@
     require_once("../../config.php");
     require_once("lib.php");
  
-    $id = optional_param('id');    // Course Module ID
-    $a  = optional_param('a');
-
+    $id = optional_param('id', 0, PARAM_INT);  // Course Module ID
+    $a  = optional_param('a', 0, PARAM_INT);   // Assignment ID
 
     if ($id) {
         if (! $cm = get_record("course_modules", "id", $id)) {