assign admins page should respect MAX_USERS_PER_PAGE

diff --git a/admin/admin.html b/admin/admin.html
index 5d37598c39951795f3df906dd11bccaa2e8b2840..b9913fc059b912ce7ded2d4c2c941392190ad466 100644 (file)
--- a/admin/admin.html
+++ b/admin/admin.html
@@ -62,11 +62,17 @@
                       echo "<option value=\"$user->id\">".$fullname.", ".$user->email."</option>\n";
                   }
                   echo "</optgroup>\n";
-              }
-              if (!empty($users)) {
-                  foreach ($users as $user) {
-                      $fullname = fullname($user, true);
-                      echo "<option value=\"$user->id\">".$fullname.", ".$user->email."</option>\n";
+              } else {
+                  if ($usercount > MAX_USERS_PER_PAGE) {
+                      echo '<optgroup label="'.get_string('toomanytoshow').'"><option></option></optgroup>'."\n"
+                          .'<optgroup label="'.get_string('trysearching').'"><option></option></optgroup>'."\n";
+                  } else {
+                      if (!empty($users)) {
+                          foreach ($users as $user) {
+                              $fullname = fullname($user, true);
+                              echo "<option value=\"$user->id\">".$fullname.", ".$user->email."</option>\n";
+                          }
+                      }
                   }
               }
           ?>

diff --git a/admin/admin.php b/admin/admin.php
index 8744c0a6dda412966053954b13189821ef1d26e8..68568dff4809b8b9cb9810b751c2c595b089d68c 100644 (file)
--- a/admin/admin.php
+++ b/admin/admin.php
@@ -101,11 +101,18 @@
 
 /// If no search results then get potential users excluding current admins
     if (empty($searchusers)) {
-        if (!$users = get_users(true, '', true, $adminlist, 'firstname ASC, lastname ASC', '', '',
-                                0, 99999, 'id, firstname, lastname, email') ) {
-            $users = array();
+
+        $usercount =  get_users(false, '', true, $adminlist, 'firstname ASC, lastname ASC', '', '',
+                                0, 99999, 'id, firstname, lastname, email');
+
+        $users = array();
+
+        if ($usercount <= MAX_USERS_PER_PAGE) {
+            if (!$users = get_users(true, '', true, $adminlist, 'firstname ASC, lastname ASC', '', '',
+                               0, 99999, 'id, firstname, lastname, email') ) {
+                $users = array();
+            }
         }
-        $usercount = count($users);
     }
 
     $searchtext = (isset($frm->searchtext)) ? $frm->searchtext : "";