MDL-12711 use 'checked' value for enabled resource_popup; merged from MOODLE_19_STABLE

diff --git a/mod/resource/settings.php b/mod/resource/settings.php
index ff2e2ffcd6e3ca258fdc39569f63b2287c0eeed5..242f49389f777243dcdbdfd3b3f688c0a0cb5601 100644 (file)
--- a/mod/resource/settings.php
+++ b/mod/resource/settings.php
@@ -21,9 +21,9 @@ $settings->add(new admin_setting_configpasswordunmask('resource_secretphrase', g
 $settings->add(new admin_setting_configcheckbox('resource_allowlocalfiles', get_string('allowlocalfiles', 'resource'),
                    get_string('configallowlocalfiles', 'resource'), 0));
 
-$woptions = array(0 => get_string('pagewindow', 'resource'), 1 => get_string('newwindow', 'resource'));
+$woptions = array('' => get_string('pagewindow', 'resource'), 'checked' => get_string('newwindow', 'resource'));
 $settings->add(new admin_setting_configselect('resource_popup', get_string('display', 'resource'),
-                   get_string('configpopup', 'resource'), 0, $woptions));
+                   get_string('configpopup', 'resource'), '', $woptions));
 
 foreach ($RESOURCE_WINDOW_OPTIONS as $optionname) {
     $popupoption = "resource_popup$optionname";