MDL-17524 Deleting a calculated question delete datasetdefinitions shared by other...

} missing...

diff --git a/question/type/calculated/questiontype.php b/question/type/calculated/questiontype.php
index 685b9492c2ee6cc5c99b471fc7c92f8bd4355d0a..7db457554663d3e8ca13815a87fdcd95db044b37 100644 (file)
--- a/question/type/calculated/questiontype.php
+++ b/question/type/calculated/questiontype.php
@@ -636,8 +636,9 @@ class question_calculated_qtype extends default_questiontype {
                         'question_datasets',
                         "question != ?
                         AND datasetdefinition = ?;", array($questionid, $dataset->datasetdefinition))){                                 
-                $DB->delete_records('question_dataset_definitions', array('id' => $dataset->datasetdefinition));
-                $DB->delete_records('question_dataset_items', array('definition' => $dataset->datasetdefinition));
+                    $DB->delete_records('question_dataset_definitions', array('id' => $dataset->datasetdefinition));
+                    $DB->delete_records('question_dataset_items', array('definition' => $dataset->datasetdefinition));
+                }
             }
         }
         $DB->delete_records("question_datasets", array("question" => $questionid));