It's not required that all modules have the old upgrade function and

the new upgrade function.

diff --git a/lib/adminlib.php b/lib/adminlib.php
index 13a8edae0bfe524365e9ea5d3c2187182131ea80..3bc935827d6ad37c98c5f5cab47e33cad3067d40 100644 (file)
--- a/lib/adminlib.php
+++ b/lib/adminlib.php
@@ -243,7 +243,6 @@ function upgrade_activity_modules($return) {
                 } else {
                     notify ('Upgrade function ' . $oldupgrade_function . ' was not available in ' .
                              $mod . ': ' . $fullmod . '/db/' . $CFG->dbtype . '.php');
-                    continue;
                 }
 
             /// Then, the new function if exists and the old one was ok
@@ -254,11 +253,10 @@ function upgrade_activity_modules($return) {
                 } else {
                     notify ('Upgrade function ' . $newupgrade_function . ' was not available in ' .
                              $mod . ': ' . $fullmod . '/db/upgrade.php');
-                    continue;
                 }
 
             /// Now analyze upgrade results
-                if ($oldupgrade_status && $newupgrade_status) {
+                if ($oldupgrade_status && $newupgrade_status) {    // No upgrading failed
                     $db->debug=false;
                     // OK so far, now update the modules record
                     $module->id = $currmodule->id;