Merged default categpory fix from stable

diff --git a/mod/quiz/lib.php b/mod/quiz/lib.php
index 654b0b75293a07649d60118ba561305588af968d..d90ebe30436cf2816ffeb66761e40945359871f2 100644 (file)
--- a/mod/quiz/lib.php
+++ b/mod/quiz/lib.php
@@ -1124,14 +1124,19 @@ function quiz_get_category_menu($courseid, $published=false) {
 }
 
 function quiz_print_category_form($course, $current) {
-// Prints a form to choose categories
+/// Prints a form to choose categories
 
-    if (!$categories = get_records_select("quiz_categories", "course = '$course->id' OR publish = '1'", "name ASC")) {
+/// Make sure the default category exists for this course
+    if (!$categories = get_records("quiz_categories", "course", $course->id, "id ASC")) {
         if (!$category = quiz_get_default_category($course->id)) {
             notify("Error creating a default category!");
-            return false;
         }
-        $categories[$category->id] = $category;
+    }
+
+/// Get all the existing categories now
+    if (!$categories = get_records_select("quiz_categories", "course = '$course->id' OR publish = '1'", "name ASC")) {
+        notify("Could not find any question categories!");
+        return false;    // Something is really wrong
     }
     foreach ($categories as $key => $category) {
        if ($catcourse = get_record("course", "id", $category->course)) {