]> git.mjollnir.org Git - moodle.git/commitdiff
course/lib: print_course() fix bug when $course->managers was not set
authormartinlanghoff <martinlanghoff>
Wed, 19 Sep 2007 07:52:27 +0000 (07:52 +0000)
committermartinlanghoff <martinlanghoff>
Wed, 19 Sep 2007 07:52:27 +0000 (07:52 +0000)
Fix a thinko in a variable assignment that prevented us from grabbing
the correct roles as managers. Addresses Yu's report at
MDL-11182 admin shows up as teacher.

course/lib.php

index 7597df2fe5ba47f4929d3cdb41ec602a9bf666a9..76f3a7a89bfe3a29de2d657f4a88df425b1e77d8 100644 (file)
@@ -1820,8 +1820,8 @@ function print_course($course) {
     
     /// first find all roles that are supposed to be displayed
     
-    if ($managerroles = !empty($CFG->coursemanager)) {
-        $coursemanagerroles = split(',', $managerroles);
+    if (!empty($CFG->coursemanager)) {
+        $managerroles = split(',', $CFG->coursemanager);
         $canseehidden = has_capability('moodle/role:viewhiddenassigns', $context);
         $namesarray = array();
         if (isset($course->managers)) {
@@ -1838,7 +1838,7 @@ function print_course($course) {
                 }
             }
         } else {
-            $rusers = get_role_users($coursemanagerroles, $context, 
+            $rusers = get_role_users($managerroles, $context, 
                                      true, '', 'r.sortorder ASC, u.lastname ASC', $canseehidden);
             if (is_array($rusers) && count($rusers)) {
                 $canviewfullnames = has_capability('moodle/site:viewfullnames', $context);